Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename uri to url (uri remains deprecated) #277

Merged
merged 1 commit into from
May 21, 2018
Merged

Rename uri to url (uri remains deprecated) #277

merged 1 commit into from
May 21, 2018

Conversation

Jhuni0123
Copy link
Contributor

@Jhuni0123 Jhuni0123 added dfct:easy Difficulty: Easy typ:refactor Type: Refactoring (i.e., the same feature to end users but its internal change) cmp:compiler Component: Compiler backend (e.g., annotation processors, code generators) cmp:runtime Component: Target runtimes cat:lang Category: Language design labels May 21, 2018
@Jhuni0123 Jhuni0123 self-assigned this May 21, 2018
@codecov
Copy link

codecov bot commented May 21, 2018 •
edited
Loading

Codecov Report

Merging #277 into master will decrease coverage by 0.02%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #277      +/-   ##
==========================================
- Coverage   77.18%   77.15%   -0.03%     
==========================================
  Files          34       34              
  Lines        2643     2644       +1     
  Branches      139      140       +1     
==========================================
  Hits         2040     2040              
  Misses        464      464              
- Partials      139      140       +1
Impacted Files Coverage Δ
src/Nirum/Constructs/TypeDeclaration.hs 77.77% <ø> (ø) ⬆️
src/Nirum/Targets/Python/Deserializers.hs 90.38% <ø> (ø) ⬆️
src/Nirum/Constructs/Module.hs 68.62% <0%> (-1.38%) ⬇️
src/Nirum/Targets/Python/Serializers.hs 79.48% <100%> (ø) ⬆️
src/Nirum/Targets/Python/Validators.hs 82.05% <100%> (ø) ⬆️
src/Nirum/Targets/Python/TypeExpression.hs 94.82% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12b57e3...e0109d6. Read the comment docs.

@dahlia dahlia merged commit e0109d6 into nirum-lang:master May 21, 2018
dahlia pushed a commit that referenced this pull request May 21, 2018
Merge pull request #277 from Jhuni0123/rename-uri-to-url
0ee591b 
Rename uri to url (uri remains deprecated)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dahlia dahlia dahlia approved these changes

@kanghyojun kanghyojun kanghyojun approved these changes

Assignees

@Jhuni0123 Jhuni0123

Labels
cat:lang Category: Language design cmp:compiler Component: Compiler backend (e.g., annotation processors, code generators) cmp:runtime Component: Target runtimes dfct:easy Difficulty: Easy typ:refactor Type: Refactoring (i.e., the same feature to end users but its internal change)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Jhuni0123 @dahlia @kanghyojun