From e2cdc3e0b146f9ce5856e247fb07a8a46df0f937 Mon Sep 17 00:00:00 2001 From: Vikram Date: Sat, 11 Jul 2020 13:09:27 +0530 Subject: [PATCH 1/3] Fixed some accessibility issues --- index.css | 647 +++++++++++++++++++++++++++-------------------------- index.html | 12 +- 2 files changed, 330 insertions(+), 329 deletions(-) diff --git a/index.css b/index.css index e12be42..2c0d0c6 100644 --- a/index.css +++ b/index.css @@ -3,116 +3,115 @@ /* --------------------------------------- */ @font-face { - font-family: 'Hk Grotesk'; - font-style: normal; - font-weight: 400; - src: url('./fonts/HKGrotesk-Regular.woff') format('woff'); + font-family: "Hk Grotesk"; + font-style: normal; + font-weight: 400; + src: url("./fonts/HKGrotesk-Regular.woff") format("woff"); } @font-face { - font-family: 'Jost'; - font-style: normal; - font-weight: 400; - src: url('./fonts/Jost-Regular.ttf') format('woff'); + font-family: "Jost"; + font-style: normal; + font-weight: 400; + src: url("./fonts/Jost-Regular.ttf") format("woff"); } * { - margin: 0; - padding: 0; - box-sizing: inherit; + margin: 0; + padding: 0; + box-sizing: inherit; } :root { - --font-size-small: 1.8rem; - --font-size-normal: 2.2rem; - --font-size-medium: 2.8rem; - --font-size-medium-1: 3.6rem; - --font-size-large: 5.5rem; - --font-size-huge: 7.5rem; - --font-stack: 'Hk Grotesk', sans-serif; + --font-size-small: 1.8rem; + --font-size-normal: 2.2rem; + --font-size-medium: 2.8rem; + --font-size-medium-1: 3.6rem; + --font-size-large: 5.5rem; + --font-size-huge: 7.5rem; + --font-stack: "Hk Grotesk", sans-serif; - --line-height-normal: 1.7; - --line-height-small: 1.2; + --line-height-normal: 1.7; + --line-height-small: 1.2; - --black: #000; - --pink: #ff3258; - --white: #f0e9f2; - --white-1: #e5e5e6da; + --black: #000; + --pink: #ff3258; + --white: #f0e9f2; + --white-1: #e5e5e6da; + --container-max-width: 1180px; + --container-normal-width: 800px; + --container-medium-width: 700px; + --container-small-width: 500px; - --container-max-width: 1180px; - --container-normal-width: 800px; - --container-medium-width: 700px; - --container-small-width: 500px; + --gutter-huge: 12rem; + --gutter-medium: 6rem; + --gutter-normal: 3rem; + --gutter-small-1: 2.5rem; + --gutter-small: 2rem; - --gutter-huge: 12rem; - --gutter-medium: 6rem; - --gutter-normal: 3rem; - --gutter-small-1: 2.5rem; - --gutter-small: 2rem; - - --border-light: 1px solid rgb(36, 35, 35); + --border-light: 1px solid rgb(36, 35, 35); } html { - font-size: 62.5%; /* (16/10)*100 = 62.5% => 1rem = 10px */ - box-sizing: border-box; - scroll-behavior: smooth; + font-size: 62.5%; /* (16/10)*100 = 62.5% => 1rem = 10px */ + box-sizing: border-box; + scroll-behavior: smooth; } -@media(max-width: 1000px) { - html { - font-size: 52%; - } +@media (max-width: 1000px) { + html { + font-size: 52%; + } } body { - font-size: var(--font-size-small); - font-family: var(--font-stack); - font-weight: 400; - color: var(--white-1); - line-height: var(--line-height-normal); - background: var(--black); - overflow-x: hidden; + font-size: var(--font-size-small); + font-family: var(--font-stack); + font-weight: 400; + color: var(--white-1); + line-height: var(--line-height-normal); + background: var(--black); + overflow-x: hidden; } .row { - max-width: var(--container-max-width); - margin: 0 auto; + max-width: var(--container-max-width); + margin: 0 auto; } -@media(max-width: 1340px) { - .row { - max-width: 1100px; - } +@media (max-width: 1340px) { + .row { + max-width: 1100px; + } } -@media(max-width: 1240px) { - .row { - padding: 0 var(--gutter-medium); - } +@media (max-width: 1240px) { + .row { + padding: 0 var(--gutter-medium); + } } -@media(max-width: 600px) { - .row { - padding: 0 var(--gutter-normal); - } +@media (max-width: 600px) { + .row { + padding: 0 var(--gutter-normal); + } } -@media(max-width: 600px) { - .row { - padding: 0 var(--gutter-small); - } +@media (max-width: 600px) { + .row { + padding: 0 var(--gutter-small); + } } section { - padding: var(--gutter-huge) 0; - border-bottom: var(--border-light); + padding: var(--gutter-huge) 0; + border-bottom: var(--border-light); } img { - object-fit: contain; - max-width: 100%; + object-fit: contain; + max-width: 100%; } /* --------------------------------------- */ @@ -122,65 +121,65 @@ img { h1, h2, h3 { - font-family: 'Jost', sans-serif; - font-weight: 400; - line-height: var(--line-height-small); - color: var(--white); + font-family: "Jost", sans-serif; + font-weight: 400; + line-height: var(--line-height-small); + color: var(--white); } .heading-primary { - line-height: 1; - font-size: var(--font-size-huge); - font-weight: 400; + line-height: 1; + font-size: var(--font-size-huge); + font-weight: 400; } -@media(max-width: 900px) { - .heading-primary { - font-size: 6.5rem; - } +@media (max-width: 900px) { + .heading-primary { + font-size: 6.5rem; + } } h2 { - font-size: var(--font-size-large); - margin-bottom: var(--gutter-medium); + font-size: var(--font-size-large); + margin-bottom: var(--gutter-medium); } h2::after { - content: ''; - display: block; - height: 2px; - width: 10rem; - background: var(--pink); - margin: var(--gutter-small) 0; + content: ""; + display: block; + height: 2px; + width: 10rem; + background: var(--pink); + margin: var(--gutter-small) 0; } h3 { - font-size: var(--font-size-medium-1); - margin-bottom: var(--gutter-small); + font-size: var(--font-size-medium-1); + margin-bottom: var(--gutter-small); } -@media(max-width: 500px) { - .heading-primary { - font-size: var(--font-size-large); - } +@media (max-width: 500px) { + .heading-primary { + font-size: var(--font-size-large); + } - h2 { - font-size: var(--font-size-medium-1); - } + h2 { + font-size: var(--font-size-medium-1); + } - h3 { - font-size: var(--font-size-medium); - } + h3 { + font-size: var(--font-size-medium); + } } p { - margin: var(--gutter-small-1) 0; + margin: var(--gutter-small-1) 0; } -@media(max-width: 900px) { - p { - max-width: var(--container-small-width); - } +@media (max-width: 900px) { + p { + max-width: var(--container-small-width); + } } /* --------------------------------------- */ @@ -188,147 +187,149 @@ p { /* --------------------------------------- */ a { - color: var(--white); - font-weight: 400; - font-family: 'Jost', sans-serif; - transition: all .2s; - outline: 2px solid transparent; + color: var(--white); + font-weight: 400; + font-family: "Jost", sans-serif; + transition: all 0.2s; + outline: 2px solid transparent; } ::-moz-focus-inner { - border: 0; + border: 0; } button:focus, a:focus { - outline: 2px solid var(--pink); + outline: 2px solid var(--pink); } body:not(.user-is-tabbing) button:focus, body:not(.user-is-tabbing) a:focus { - outline: none; + outline: none; } .link:hover { - color: var(--pink); + color: var(--pink); } .btn { - position: relative; - display: inline-block; - padding: 1rem 4.2rem; - text-decoration: none; - color: inherit; - border: 1px solid var(--pink); - font-weight: 400; + position: relative; + display: inline-block; + padding: 1rem 4.2rem; + text-decoration: none; + color: #000; + font-weight: 400; + box-sizing: border-box; } .btn:focus { - outline: none; + outline: none; } .btn::after { - content: ''; - display: block; - position: absolute; - top: 0; - left: 0; - right: 100%; - background: var(--white); - height: 100%; - z-index: -1; - transition: all 0.2s cubic-bezier(1, 0.68, 0.16, 0.9); + content: ""; + display: block; + position: absolute; + top: 0; + left: 0; + right: 100%; + background: var(--white); + height: 100%; + z-index: -1; + transition: all 0.2s cubic-bezier(1, 0.68, 0.16, 0.9); } .btn:hover::after, .btn:focus::after { - right: 0; - background: var(--pink); + right: 0; + background: var(--pink); } .btn--pink { - background: var(--pink); - transition: all 0.2s; + background: white; + transition: all 0.2s; } .btn--pink::after { - display: none; + display: none; } .btn--pink:hover, .btn--pink:focus { - background: transparent; + background: transparent; + border: 1px solid white; + color: white; } .link__text { - position: relative; - display: inline-block; - padding: .6rem; - color: inherit; - text-decoration: none; - border-bottom: 1px solid var(--pink); + position: relative; + display: inline-block; + padding: 0.6rem; + color: inherit; + text-decoration: none; + border-bottom: 1px solid var(--pink); } .link__text::after { - content: ''; - display: block; - position: absolute; - top: 0; - left: 0; - right: 100%; - background: var(--white); - height: 100%; - z-index: -1; - transition: all 0.2s cubic-bezier(1, 0.68, 0.16, 0.9); + content: ""; + display: block; + position: absolute; + top: 0; + left: 0; + right: 100%; + background: var(--white); + height: 100%; + z-index: -1; + transition: all 0.2s cubic-bezier(1, 0.68, 0.16, 0.9); } .link__text:focus { - outline: none; + outline: none; } .link__text:hover::after, .link__text:focus:after { - right: 0; - background: var(--pink); + right: 0; + background: var(--pink); } .link__text span { - padding-left: 1rem; - font-family: sans-serif; + padding-left: 1rem; + font-family: sans-serif; } /* ----- Back to Top ----- */ .back-to-top { - position: fixed; - bottom: 4rem; - right: 4rem; - display: flex; - justify-content: center; - align-items: center; - height: 5.5rem; - width: 5.5rem; - background-color: var(--pink); - border-radius: 50%; - z-index: 10; - visibility: hidden; - transition: all .4s; + position: fixed; + bottom: 4rem; + right: 4rem; + display: flex; + justify-content: center; + align-items: center; + height: 5.5rem; + width: 5.5rem; + background-color: var(--pink); + border-radius: 50%; + z-index: 10; + visibility: hidden; + transition: all 0.4s; } .back-to-top__image { - height: 70%; + height: 70%; } -@media(max-width: 900px) { - .back-to-top { - right: 2rem; - } +@media (max-width: 900px) { + .back-to-top { + right: 2rem; + } } -@media(max-width: 500px) { - .back-to-top { - right: 1rem; - } +@media (max-width: 500px) { + .back-to-top { + right: 1rem; + } } /* --------------------------------------- */ @@ -336,67 +337,67 @@ body:not(.user-is-tabbing) a:focus { /* --------------------------------------- */ .nav { - display: flex; - justify-content: flex-end; - padding: var(--gutter-normal) 0; + display: flex; + justify-content: flex-end; + padding: var(--gutter-normal) 0; } .nav__items { - display: flex; - list-style: none; + display: flex; + list-style: none; } .nav__item:not(:last-child) { - margin-right: var(--gutter-medium); + margin-right: var(--gutter-medium); } -@media(max-width: 500px) { - .nav { - justify-content: center; - } +@media (max-width: 500px) { + .nav { + justify-content: center; + } } -@media(max-width: 400px) { - .nav__item:not(:last-child) { - margin-right: var(--gutter-normal); - } +@media (max-width: 400px) { + .nav__item:not(:last-child) { + margin-right: var(--gutter-normal); + } } -@media(max-width: 300px) { - .nav { - font-size: var(--font-size-small); - } +@media (max-width: 300px) { + .nav { + font-size: var(--font-size-small); + } } .nav__link { - position: relative; - display: inline-block; - padding: 1rem 0; - text-decoration: none; - color: inherit; - transition: all .2s; + position: relative; + display: inline-block; + padding: 1rem 0; + text-decoration: none; + color: inherit; + transition: all 0.2s; } .nav__link::after { - content: ''; - position: absolute; - bottom: 0; - left: 0; - right: 100%; - display: inline-block; - height: 1rem; - background: var(--white); - transition: all 0.25s cubic-bezier(1, 0.68, 0.16, 0.9); + content: ""; + position: absolute; + bottom: 0; + left: 0; + right: 100%; + display: inline-block; + height: 1rem; + background: var(--white); + transition: all 0.25s cubic-bezier(1, 0.68, 0.16, 0.9); } .nav__link:hover { - color: var(--pink); + color: var(--pink); } .nav__link:hover::after { - right: 0; - height: 2px; - background: var(--pink); + right: 0; + height: 2px; + background: var(--pink); } /* --------------------------------------- */ @@ -404,36 +405,36 @@ body:not(.user-is-tabbing) a:focus { /* --------------------------------------- */ .header { - background: linear-gradient(rgba(0,0,0, .1), rgba(0,0,0, .4)), - url('./images/header.jpg'); - height: 100vh; - background-size: cover; - background-position: center; - background-attachment: fixed; - font-size: var(--font-size-normal); + background: linear-gradient(rgba(0, 0, 0, 0.1), rgba(0, 0, 0, 0.4)), + url("./images/header.jpg"); + height: 100vh; + background-size: cover; + background-position: center; + background-attachment: fixed; + font-size: var(--font-size-normal); } .header__text { - position: absolute; - top: 50%; - transform: translateY(-50%); + position: absolute; + top: 50%; + transform: translateY(-50%); } .header__text p { - margin: 1.5rem 0 3.5rem; - max-width: var(--container-medium-width); - font-family: 'Jost', sans-serif; - font-size: var(--font-size-medium); + margin: 1.5rem 0 3.5rem; + max-width: var(--container-medium-width); + font-family: "Jost", sans-serif; + font-size: var(--font-size-medium); } -@media(max-width: 500px) { - .header { - text-align: center; - } +@media (max-width: 500px) { + .header { + text-align: center; + } - .header__text p { - transform: scale(.8); - } + .header__text p { + transform: scale(0.8); + } } /* --------------------------------------- */ @@ -441,68 +442,68 @@ body:not(.user-is-tabbing) a:focus { /* --------------------------------------- */ .work__box { - display: flex; - align-items: center; + display: flex; + align-items: center; } -@media(max-width: 900px) { - .work__box { - align-items: initial; - flex-direction: column-reverse; - } +@media (max-width: 900px) { + .work__box { + align-items: initial; + flex-direction: column-reverse; + } } .work__box:not(:last-child) { - margin-bottom: 25rem; + margin-bottom: 25rem; } -@media(max-width: 500px) { - .work__box:not(:last-child) { - margin-bottom: 20rem; - } +@media (max-width: 500px) { + .work__box:not(:last-child) { + margin-bottom: 20rem; + } } .work__links { - display: flex; - align-items: center; + display: flex; + align-items: center; } .work__text { - flex: 0 0 30%; + flex: 0 0 30%; } .work__list { - /* list-style-type: square; */ - list-style-position: inside; - margin-bottom: var(--gutter-normal); + /* list-style-type: square; */ + list-style-position: inside; + margin-bottom: var(--gutter-normal); } .work__code { - display: block; - height: 3rem; - margin-left: var(--gutter-normal); - transition: all .3s; + display: block; + height: 3rem; + margin-left: var(--gutter-normal); + transition: all 0.3s; } .work__code:hover { - transform: scale(1.2); + transform: scale(1.2); } .work__image-box { - margin-bottom: var(--gutter-normal); + margin-bottom: var(--gutter-normal); } -@media(min-width: 901px) { - .work__image-box { - flex: 1; - margin: 0 0 0 10rem; - } +@media (min-width: 901px) { + .work__image-box { + flex: 1; + margin: 0 0 0 10rem; + } } -@media(max-width: 900px) { - .work__code { - height: 4rem; - } +@media (max-width: 900px) { + .work__code { + height: 4rem; + } } /* --------------------------------------- */ @@ -510,25 +511,25 @@ body:not(.user-is-tabbing) a:focus { /* --------------------------------------- */ .client__logos { - display: flex; - justify-content: space-between; - filter: invert(100%) grayscale(100%) opacity(.8); + display: flex; + justify-content: space-between; + filter: invert(100%) grayscale(100%) opacity(0.8); } .client__logo { - height: 6.5rem; - max-width: 18rem; + height: 6.5rem; + max-width: 18rem; } -@media(max-width: 1240px) { - .client__logos { - overflow-x: scroll; - padding: var(--gutter-normal); - } +@media (max-width: 1240px) { + .client__logos { + overflow-x: scroll; + padding: var(--gutter-normal); + } - .client__logo:not(:last-of-type) { - margin-right: var(--gutter-medium); - } + .client__logo:not(:last-of-type) { + margin-right: var(--gutter-medium); + } } /* --------------------------------------- */ @@ -536,31 +537,31 @@ body:not(.user-is-tabbing) a:focus { /* --------------------------------------- */ .about__content { - display: flex; - flex-direction: row-reverse; - align-items: center; + display: flex; + flex-direction: row-reverse; + align-items: center; } -@media(max-width: 900px) { - .about__content { - flex-direction: column-reverse; - align-items: initial; - } +@media (max-width: 900px) { + .about__content { + flex-direction: column-reverse; + align-items: initial; + } } .about__photo-container { - margin-bottom: var(--gutter-normal); + margin-bottom: var(--gutter-normal); } -@media(min-width: 901px) { - .about__text { - flex: 0 0 35%; - } - - .about__photo-container { - flex: 1; - margin: 0 var(--gutter-huge) 0 0; - } +@media (min-width: 901px) { + .about__text { + flex: 0 0 35%; + } + + .about__photo-container { + flex: 1; + margin: 0 var(--gutter-huge) 0 0; + } } /* --------------------------------------- */ @@ -568,7 +569,7 @@ body:not(.user-is-tabbing) a:focus { /* --------------------------------------- */ .contact__info { - max-width: var(--container-medium-width); + max-width: var(--container-medium-width); } /* --------------------------------------- */ @@ -576,38 +577,38 @@ body:not(.user-is-tabbing) a:focus { /* --------------------------------------- */ .footer { - text-align: center; - padding: var(--gutter-medium) 0 var(--gutter-normal); + text-align: center; + padding: var(--gutter-medium) 0 var(--gutter-normal); } .footer__social-links { - display: flex; - justify-content: center; - padding: var(--gutter-normal) 0; - list-style: none; + display: flex; + justify-content: center; + padding: var(--gutter-normal) 0; + list-style: none; } .footer__social-link-item:not(:last-of-type) { - margin-right: var(--gutter-small); + margin-right: var(--gutter-small); } .footer__social-image { - height: 4rem; + height: 4rem; } .footer__github-buttons { - display: flex; - justify-content: center; + display: flex; + justify-content: center; } .footer__github-buttons iframe { - height: 2.5rem; - width: 80px; - transform: translateY(3px); + height: 2.5rem; + width: 80px; + transform: translateY(3px); } -@media(max-width: 500px) { - .footer { - padding: var(--gutter-medium) 0; - } +@media (max-width: 500px) { + .footer { + padding: var(--gutter-medium) 0; + } } diff --git a/index.html b/index.html index 24a3242..0a93524 100644 --- a/index.html +++ b/index.html @@ -94,12 +94,12 @@

Portfolio Template

Visit Site - GitHub + Github link to source code
- Project 1 + Image showcasing Portfolio Template
@@ -122,12 +122,12 @@

Calculator

Visit Site - GitHub + Github link to the Source Code
- Project 1 + Image showcasing Calculator Project
@@ -150,12 +150,12 @@

Notificator

Visit Site - GitHub + Github link to source code
- Project 3 + Image showcasing notificator project
From 4b5be2c2078926e8103a75a3ad2a7ba377a10456 Mon Sep 17 00:00:00 2001 From: Vikram <46264253+Vikram-Hegde@users.noreply.github.com> Date: Sun, 19 Jul 2020 17:40:50 +0530 Subject: [PATCH 2/3] Update index.css Co-authored-by: Nisar Hassan Naqvi --- index.css | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/index.css b/index.css index 2c0d0c6..4cafd34 100644 --- a/index.css +++ b/index.css @@ -246,7 +246,7 @@ body:not(.user-is-tabbing) a:focus { } .btn--pink { - background: white; + background: var(--pink); transition: all 0.2s; } From a8c4e0583b7dbf0048d725dd61acd1d6cc3115c2 Mon Sep 17 00:00:00 2001 From: Vikram <46264253+Vikram-Hegde@users.noreply.github.com> Date: Sun, 19 Jul 2020 17:41:18 +0530 Subject: [PATCH 3/3] Update index.html Co-authored-by: Nisar Hassan Naqvi --- index.html | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/index.html b/index.html index 0a93524..1b852fa 100644 --- a/index.html +++ b/index.html @@ -99,7 +99,7 @@

Portfolio Template

- Image showcasing Portfolio Template + Portfolio Template
@@ -273,4 +273,4 @@

Get in Touch

- \ No newline at end of file +