New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i6889 fix excel merged cell regression #1

Closed
wants to merge 1 commit into
base: i3044-excel-cellborder
from

Conversation

Projects
None yet
1 participant
@feerrenrut

feerrenrut commented Feb 17, 2017

This issue seems to effect excel 2007, and not excel 2013.

The relevant difference in the API is the DisplayFormat property that exists in excel 2013 but not in excel 2007. If the call to DisplayFormat fails instead we access the borders via the range.borders property.

get cell borders in excel 2007
Fixes nvaccess#6889
The `DisplayFormat` property does not exist on ranges for excel 2007.
Instead (if the call to DisplayFormat fails) the borders property is
accessed directly on the range object rather than through the `DisplayFormat`
@feerrenrut

This comment has been minimized.

feerrenrut commented Feb 17, 2017

Oops I am going to close this and make the PR against the nvaccess NVDA repo directly.

@feerrenrut feerrenrut closed this Feb 17, 2017

nishimotz added a commit to nvdajp/nvdajp that referenced this pull request Feb 21, 2017

nishimotz pushed a commit that referenced this pull request Aug 21, 2017

Merge pull request #1 from nishimotz/in-t2990-review
fixes some issues with UnicodeEncodeError and log messages, fixes handling of number characters followed by Japanese
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment