Add ability to change element type

[th3fallen]

By default you add a span but that causes issues with bootstrap v4 would be nice if we had the option to change it to say a div or something of the sorts...

[th3fallen]

or the ability to add classes to the span wrapper would work as well

[nitin42]

I am experimenting on this. It won't be appropriate to add classes to the wrapper (using styled-components keyframes)

[nitin42]

Haven't tried this with Bootstrap v4. Are you sure that it causes issues ?

[nitin42]

How about if we enclose it like this ?

<div>
  <Bounce>
    <p>Hello</p>
  </Bounce>
</div>

[th3fallen]

It causes issues with notices particularly (only place i've used them thus far... but here's with it being inline-block'd vs block'd

inline block
http://th3fallen.d.pr/ygX2

block
http://th3fallen.d.pr/bFre

I had to wrap it in a div with a class so i could target the span and force it to display block

[th3fallen]

even if we couldnt add custom classes to it, a class to identify it would be super handy for this. atm there's no way to target that span without wrapping it.

[nitin42]

Ok. So what you are saying is that HOC should render the props.children inside a <div> wrapper instead of span which causes the display to be inline. Right ?

[nitin42]

That may target the children nodes to display block.

<div {...this.state.styles}>
  {this.props.children}
</div>

[th3fallen]

yes that would solve it but may cause backwards compat issues for other users of the lib which is why i was originally asking for the option to change it with a prop could be as simple as

<Bounce block>
    <p>Hello</p>
  </Bounce>

which would then render a div vs a span

[nitin42]

I think this would be better. Thanks !

[th3fallen]

anytime! thanks for the library, saves me so much pain, just wish i handled components transitioning out. :(

[nitin42]

May be I would land the transitioning soon 😄 .

[nitin42]

Added support for rendering an animation component with prop block. Check it out and let me know. Also check the docs.

[nitin42]

Does react-motion tries to solve Component Transitioning ? I've never used it before. Seems a little complex and full of abstraction.