Skip to content

Conversation

@tlebreton
Copy link

Hi

I made this pr to update your project with angular 17.

I take the opportunity to update all the packages except husky (breaking change after v4).

Thanks for your library :)

Closes #117

Copy link
Owner

@nivekcode nivekcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @tlebreton thx a lot for the changes. Very appreciated. The changes look good, but the commit message is not properly formatted. Having the proper conventional commit format is important since we use a fully automated release process. Means the commit message is analyzed and based on that the new version is calculated.

With this change the library can only be used with Angular 17 - (technically you could still use it with 16 but you would get install warnings or depending on the node version install errors).

Therefore I consider this change as a breaking change. This means that the commit message should by of type feat and include a commit body. A commit message could look something like this:

feat: migrate to Angular 17

BREAKING CHANGE: Angular 17

@tlebreton
Copy link
Author

Hi

Oups my bad ...

I amend my last commit and force push a new one. (if you want i can restart a new PR with somethink cleaner)

@nivekcode
Copy link
Owner

@tlebreton thx, the changes look good. 👍

@nivekcode nivekcode merged commit b0c4216 into nivekcode:master Mar 18, 2024
@nivekcode
Copy link
Owner

🎉 This PR is included in version 17.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Angular 17

2 participants