Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for specifying separate configuration and mount points for BTRFS subvolumes by implementing them as a new subtype for the
btrfs
typeIt sort of follows from the work in #33, but does not use any of that implementation because disko has largely been rewritten since then to use types
I believe I've done everything mostly reasonably (since I copied the patterns LVM and ZFS were using for the most part), but I don't actually fully know what I'm doing, so please let me know if some things should be done differently
I've tested this by installing my new laptop from my config (see the disko config here) and via the flake checks in disko
Also of note: With the way this works, it does not create separate mountpoints if the parent btrfs filesystem has a mountpoint specified and the subvolume does not have one specified (it only gets created via
btrfs subvolume create
). That means this PR follows previous behavior when changing:to:
even though changing the type is a breaking change.