-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mako: add module #1113
mako: add module #1113
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your work on this! Keep in mind I only briefly looked this over.
First thing's first: please reflow all descriptions to fit within ~80 characters (or whatever is most common in the other modules). This makes it easier for reviewers like myself to read the entire context without having to scroll left and right repeatedly.
|
Should be fixed now, thank you for this feedback :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please run the format script at the root of the repository to make CI happy :)
|
looks good now :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor style nit: some of the descriptions appear to be indented quite a bit compared to some others. Otherwise, LGTM.
(Note: I haven't actually used this.)
|
Good point! Should be fixed now :) |
|
I noticed that a similar program called |
|
Okay seems to be fixed :) |
|
Thanks! Rebased to master in f856da6. It's a bit unusual to place a module inside the service namespace when the module doesn't define an actual service, though. |
Configuration modul for Wayland notification daemon mako :)
Best regards
Jonas