Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mako: add module #1113

Closed
wants to merge 18 commits into from
Closed

mako: add module #1113

wants to merge 18 commits into from

Conversation

onny
Copy link
Contributor

@onny onny commented Mar 23, 2020

Configuration modul for Wayland notification daemon mako :)
Best regards
Jonas

Copy link
Member

@cole-h cole-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work on this! Keep in mind I only briefly looked this over.

First thing's first: please reflow all descriptions to fit within ~80 characters (or whatever is most common in the other modules). This makes it easier for reviewers like myself to read the entire context without having to scroll left and right repeatedly.

modules/programs/mako.nix Outdated Show resolved Hide resolved
modules/programs/mako.nix Outdated Show resolved Hide resolved
modules/programs/mako.nix Outdated Show resolved Hide resolved
modules/programs/mako.nix Outdated Show resolved Hide resolved
modules/programs/mako.nix Outdated Show resolved Hide resolved
modules/programs/mako.nix Outdated Show resolved Hide resolved
modules/programs/mako.nix Outdated Show resolved Hide resolved
modules/programs/mako.nix Outdated Show resolved Hide resolved
modules/programs/mako.nix Outdated Show resolved Hide resolved
modules/programs/mako.nix Outdated Show resolved Hide resolved
@onny
Copy link
Contributor Author

onny commented Apr 1, 2020

Should be fixed now, thank you for this feedback :)

Copy link
Member

@cole-h cole-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run the format script at the root of the repository to make CI happy :)

@onny
Copy link
Contributor Author

onny commented Apr 4, 2020

looks good now :)

Copy link
Member

@cole-h cole-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor style nit: some of the descriptions appear to be indented quite a bit compared to some others. Otherwise, LGTM.

(Note: I haven't actually used this.)

modules/programs/mako.nix Outdated Show resolved Hide resolved
modules/programs/mako.nix Outdated Show resolved Hide resolved
@onny
Copy link
Contributor Author

onny commented Apr 5, 2020

Good point! Should be fixed now :)

@onny
Copy link
Contributor Author

onny commented Apr 5, 2020

I noticed that a similar program called dunst is placed inside the modules/services directory. Should this module also belong in this place?

@onny
Copy link
Contributor Author

onny commented Apr 8, 2020

Okay seems to be fixed :)

rycee pushed a commit that referenced this pull request Apr 9, 2020
rycee pushed a commit that referenced this pull request Apr 9, 2020
@rycee
Copy link
Member

rycee commented Apr 9, 2020

Thanks! Rebased to master in f856da6. It's a bit unusual to place a module inside the service namespace when the module doesn't define an actual service, though.

@rycee rycee closed this Apr 9, 2020
jorsn pushed a commit to jorsn/home-manager that referenced this pull request Apr 25, 2020
NickHu pushed a commit to NickHu/home-manager that referenced this pull request May 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants