Skip to content

kakoune: implement whitespace highlighter#1162

Closed
dermetfan wants to merge 3 commits into
nix-community:masterfrom
dermetfan:kakoune
Closed

kakoune: implement whitespace highlighter#1162
dermetfan wants to merge 3 commits into
nix-community:masterfrom
dermetfan:kakoune

Conversation

@dermetfan
Copy link
Copy Markdown
Collaborator

programs.kakoune.config.showWhitespace existed but was not implemented.

I added the test to the formatter's skip list because it adds even more escapes to the regex.

Checklist

  • Code formatted with ./format.

  • Code tested through nix-shell --pure tests -A run.all. (no new failures)

  • Test cases updated/added.

  • Commit messages are formatted like

    {component}: {description}
    
    {long description}
    

@dermetfan dermetfan requested a review from rycee as a code owner April 16, 2020 20:12
rycee pushed a commit that referenced this pull request Apr 16, 2020
The options under `programs.kakoune.config.showWhitespace` existed
but were not implemented.

PR #1162
@rycee
Copy link
Copy Markdown
Member

rycee commented Apr 16, 2020

Thanks! Squashed and rebased to master in 86ccd8f. Note, I removed the formatting exception for the test case. My hope is to remove all exceptions at some point the future and think its OK to let nixfmt produce a few oddities here and there 🙂

@rycee rycee closed this Apr 16, 2020
@dermetfan dermetfan deleted the kakoune branch April 16, 2020 20:42
jorsn pushed a commit to jorsn/home-manager that referenced this pull request Apr 25, 2020
The options under `programs.kakoune.config.showWhitespace` existed
but were not implemented.

PR nix-community#1162
NickHu pushed a commit to NickHu/home-manager that referenced this pull request May 19, 2020
The options under `programs.kakoune.config.showWhitespace` existed
but were not implemented.

PR nix-community#1162
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants