kakoune: implement whitespace highlighter #1162
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The options under `programs.kakoune.config.showWhitespace` existed but were not implemented.
rycee
pushed a commit
that referenced
this pull request
Apr 16, 2020
The options under `programs.kakoune.config.showWhitespace` existed but were not implemented. PR #1162
|
Thanks! Squashed and rebased to master in 86ccd8f. Note, I removed the formatting exception for the test case. My hope is to remove all exceptions at some point the future and think its OK to let nixfmt produce a few oddities here and there 🙂 |
jorsn
pushed a commit
to jorsn/home-manager
that referenced
this pull request
Apr 25, 2020
The options under `programs.kakoune.config.showWhitespace` existed but were not implemented. PR nix-community#1162
NickHu
pushed a commit
to NickHu/home-manager
that referenced
this pull request
May 19, 2020
The options under `programs.kakoune.config.showWhitespace` existed but were not implemented. PR nix-community#1162
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
programs.kakoune.config.showWhitespaceexisted but was not implemented.I added the test to the formatter's skip list because it adds even more escapes to the regex.
Checklist
Code formatted with
./format.Code tested through
nix-shell --pure tests -A run.all. (no new failures)Test cases updated/added.
Commit messages are formatted like