picom: add windowType option#1163
Conversation
It was previously not possible to configure other windows types because the window key was already used.
| }; | ||
| }; | ||
| default = { }; | ||
| description = "Specific settings for this window type."; |
There was a problem hiding this comment.
This sounds very generic, specifically what does "this" refer to w.r.t window types?
There was a problem hiding this comment.
The same holds for the descriptions above.
| notify = rulesOption; | ||
| combo = rulesOption; | ||
| dnd = rulesOption; | ||
| }; |
There was a problem hiding this comment.
From what I can tell this will introduce something like 90 options, does picom make any guarantees that these options are safe w.r.t backward and forward compatibility? If not then this could be quite unpleasant to maintain. Would it be possible to do something more in line of RFC #42?
|
Thanks for the contribution! I've added a few comments. |
|
I'm inclined to close this PR without merging due to the large number of options and that nobody has been pushing particularly hard for this to go in. I will close for now, if anybody disagrees then feel free to make a comment and re-open. |
2 participants
Description
It was previously not possible to configure other windows types through
extraConfigbecause thewintypeskey was already used. Adding this option allows unlimited configuration.I kept
noDNDShadow,noDockShadow, andmenuOpacityas shortcuts.Checklist
Code formatted with
./format.Code tested through
nix-shell --pure tests -A run.all. (no new failures)[ ] Test cases updated/added.Commit messages are formatted like