sway: add config.bindkeysToCode

[rvolosatovs]

Description

Do not use --to-code by default in bindsym, let user configure that behavior manually via config.bindkeysToCode in sway module.

Refs #1229 (comment)

Checklist

• Change is backwards compatible.

• Code formatted with ./format.

• Code tested through nix-shell --pure tests -A run.all.

tests fail with:

hash mismatch in fixed-output derivation '/nix/store/sd0pnznvqy3l9k773anr14kv5imchvg8-delta-0.0.16-vendor.tar.gz':
  wanted: sha256:1zmk70hccrxn1gdr1bksnvh6sa2h4518s0ni8k2ihxi4ld1ch5p2
  got:    sha256:0hah0qfgnl4w2h0djyh4xx1jks5dkzwin01qw001dqiasl60prn2
cannot build derivation '/nix/store/a9j70nsz3x37mkakcqjw60rl1zs4s4p6-delta-0.0.16.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/7z4qg944anpk1hfjfaxx9zv13c9bpinx-git-expected.conf.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/75y9mfswm5x82lrj28dii5yg6lyzmg68-hm_gitconfig.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/bc22arqm3vjb37jqdb2lag30p2rj9ajv-home-manager-files.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/2zzxyhscan5n2zgjqflbhkcc5vrcjvqh-nmt-test-script-git-with-most-options.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/zrdw6v8dixg1gap8scw11i8ccjh79hgv-nmt-report-git-with-most-options.drv': 1 dependencies couldn't be built
error: build of '/nix/store/zrdw6v8dixg1gap8scw11i8ccjh79hgv-nmt-report-git-with-most-options.drv' failed

• Test cases updated/added. See example.

• Commit messages are formatted like

  {component}: {description}
  
  {long description}
  

  See CONTRIBUTING for more information and recent commit messages for examples.

• If this PR adds a new module

  • Added myself as module maintainer. See example.

  • Added myself and the module files to .github/CODEOWNERS.

[rvolosatovs]

cc @dermetfan for testing

[dermetfan]

I checked out your branch and ran the tests. I only get one failed test about formatting that can be solved with ./format. There is no hash mismatch error for me...

Patch produced by ./format

commit 079857636f08872c0c13ce198d2de717d1cc9f56 (HEAD -> fix/sway-bindkeys)
Author: Robin Stumm <serverkorken@gmail.com>
Date:   Sun May 31 15:07:05 2020 +0200

    sway: format

diff --git a/modules/services/window-managers/i3-sway/lib/functions.nix b/modules/services/window-managers/i3-sway/lib/functions.nix
index 4577d09..ea2938e 100644
--- a/modules/services/window-managers/i3-sway/lib/functions.nix
+++ b/modules/services/window-managers/i3-sway/lib/functions.nix
@@ -31,7 +31,7 @@ rec {

   modeStr = name: keybindings: ''
     mode "${name}" {
-    ${keybindingsStr { inherit keybindings; } }
+    ${keybindingsStr { inherit keybindings; }}
     }
   '';

diff --git a/modules/services/window-managers/i3-sway/sway.nix b/modules/services/window-managers/i3-sway/sway.nix
index 5c5bfa3..b000c42 100644
--- a/modules/services/window-managers/i3-sway/sway.nix
+++ b/modules/services/window-managers/i3-sway/sway.nix
@@ -268,9 +268,10 @@ let
       client.placeholder ${colorSetStr colors.placeholder}
       client.background ${colors.background}

-      ${keybindingsStr {
+      ${keybindingsStr {
         inherit keybindings;
-        bindsymArgs = lib.optionalString (cfg.config.bindkeysToCode) "--to-code";
+        bindsymArgs =
+          lib.optionalString (cfg.config.bindkeysToCode) "--to-code";
       }}
       ${keycodebindingsStr keycodebindings}
       ${concatStringsSep "\n" (mapAttrsToList inputStr input)}

[rvolosatovs]

@dermetfan can you confirm that this patch fixes your issue?

[dermetfan]

Yes, thanks for the quick reaction! No idea why Travis fails now...

[rycee]

Beside the comment I added above this looks OK to me.

The test failure is due to SRI hashes introduced in Nixpkgs, these are unsupported in the Nix version used by Travis CI. I believe the SRI hashes are being removed from Nixpkgs master which should clear up the errors once the removals hit the unstable channel.

[rycee]

Thanks! Rebased to master in 8574817.