fix home.activation.checkLinkTargets#19
Closed
dermetfan wants to merge 1 commit intonix-community:masterfrom
Closed
fix home.activation.checkLinkTargets#19dermetfan wants to merge 1 commit intonix-community:masterfrom
dermetfan wants to merge 1 commit intonix-community:masterfrom
Conversation
dermetfan
force-pushed
the
fix/checkLinkTargets
branch
from
39dd63c to
b54ad70
Compare
======================================
Problem
-------
We resolve symlinks from inside `/nix/store/HASH-home-manager-files` into the nix store as `/nix/store/HASH-DRVNAME` which does not match the pattern.
This happened to me because I pull in some repos in via `home.file`. The `home-manager-files` derivation links to the repo's derivation in the nix store. For example:
let nanorcs = fetchFromGitHub {
owner = "scopatz";
repo = "nanorc";
…
}; in [
{
target = ".nano";
source = nanorcs;
}
{
target = ".nanorc";
source = "${nanorcs}/nanorc";
}
]
Solution
--------
Call `readlink` without `-e` to obtain only the first redirection from `~` to `/nix/store/HASH-home-manager-files`.
dermetfan
force-pushed
the
fix/checkLinkTargets
branch
from
b54ad70 to
ec348e0
Compare
Member
|
Thanks for reporting :-) I think this might be a copy-paste mistake. I know that |
Member
|
Yeah, in this case it definitely should be without |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
We resolve symlinks from inside
/nix/store/HASH-home-manager-filesinto the nix store as/nix/store/HASH-DRVNAMEwhich does not match the pattern.This happened to me because I pull in some repos in via
home.file. Thehome-manager-filesderivation links to the repo's derivation in the nix store. For example:Solution
Call
readlinkwithout-eto obtain only the first redirection from~to/nix/store/HASH-home-manager-files.Why a PR?
I am unsure why you used
-ebut saw you using it consistently. Is there an edge case I failed to notice?