fix home.activation.checkLinkTargets

[dermetfan]

Problem

We resolve symlinks from inside /nix/store/HASH-home-manager-files into the nix store as /nix/store/HASH-DRVNAME which does not match the pattern.

This happened to me because I pull in some repos in via home.file. The home-manager-files derivation links to the repo's derivation in the nix store. For example:

let nanorcs = fetchFromGitHub {
  owner = "scopatz";
  repo = "nanorc";
  …
}; in [
  {
    target = ".nano";
    source = nanorcs;
  }
  {
    target = ".nanorc";
    source = "${nanorcs}/nanorc";
  }
]

Solution

Call readlink without -e to obtain only the first redirection from ~ to /nix/store/HASH-home-manager-files.

Why a PR?

I am unsure why you used -e but saw you using it consistently. Is there an edge case I failed to notice?

[rycee]

Thanks for reporting :-) I think this might be a copy-paste mistake. I know that -e is required elsewhere but it may not be the case here. I will have a closer look tomorrow (and also your other PR).

[rycee]

Yeah, in this case it definitely should be without -e. The problem only manifests itself when using home.file.blah.source = ./foo; where ./foo is a directory. Rebased this into master in cb569c5. Many thanks for catching and fixing this bug!