fix evaluation error if programs.git.extraConfig is null#2
Closed
dermetfan wants to merge 1 commit intonix-community:masterfrom
Closed
fix evaluation error if programs.git.extraConfig is null#2dermetfan wants to merge 1 commit intonix-community:masterfrom
programs.git.extraConfig is null#2dermetfan wants to merge 1 commit intonix-community:masterfrom
Conversation
Member
|
Thanks for the pull request! Good catch with this. I think the simpler solution, however, is to make the default non-null. That is to have This corresponds to the typical practice in NixOS so I'd prefer that solution. Would you mind changing the PR? Otherwise I'd be happy to fix this myself. |
dermetfan
force-pushed
the
fix-gitconfig
branch
from
62fcefa to
3f296f0
Compare
Collaborator
Author
|
Sorry, of course. Sometimes we miss the most obvious things. |
Member
|
That looks nice and simple :-) I simplified the commit message a little as well and rebased it into master in commit 386d2db. Thanks a lot for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.