Add vivaldi to chromium.nix

[robertodr]

Description

Checklist

• Change is backwards compatible.

• Code formatted with ./format.

• Code tested through nix-shell --pure tests -A run.all.

• Test cases updated/added. See example.

• Commit messages are formatted like

  {component}: {description}
  
  {long description}
  

  See CONTRIBUTING for more information and recent commit messages for examples.

• If this PR adds a new module

  • Added myself as module maintainer. See example.

  • Added myself and the module files to .github/CODEOWNERS.

[rycee]

Is this necessary?

[robertodr]

It's not, but I left it in for consistency with the other browsers. Should I remove it?

[rycee]

Yeah, I think it's best to only record differences from the default value (like in linuxDirs below).

[rycee]

Same, really necessary?

[rycee]

Thanks for the contribution! Added a few comments.

[robertodr]

I think this is ready to go.

[sumnerevans]

@robertodr still need to address the two comments from @rycee about removing the unnecessary entries in darwinDirs and linuxDirs.

[berbiche]

@rycee what is the reasoning for hiding other browsers from the documentation? (the last argument to browserModule controls the visibility)

[rycee]

I believe it was just to avoid bloating the documentation with the same options over and over just with a slightly different attribute path. Maybe it's not too bad to allow generation of this documentation. Will have to try and see.

[berbiche]

Sorry, this should have been merged a long time ago!

cc @sumnerevans

edit: After fixing the conflict in modules/programs/chromium.nix

[rycee]

I fixed up the remaining issues and rebased to master in 742c6cb.