Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

librewolf: init module #2976

Merged
merged 1 commit into from
Jul 13, 2022
Merged

librewolf: init module #2976

merged 1 commit into from
Jul 13, 2022

Conversation

onny
Copy link
Contributor

@onny onny commented May 23, 2022

Description

This PR is related to the issue #2803 .
It adds a module for the program LibreWolf, a security and privacy focused fork of Firefox.
In the current state it only adds the overrides settings to configure some LibreWolf settings as described here. This is the only option I need.
As far as I can tell this is Librewolf specific and could not be compared or covered with the Firefox module.

Example usage:

programs.librewolf = {
  enable = true;
  # Enable WebGL, cookies and history
  overrides = {
    "webgl.disabled" = false;
    "privacy.resistFingerprinting" = false;
    "privacy.clearOnShutdown.history" = false;
    "privacy.clearOnShutdown.cookies" = false;
    "network.cookie.lifetimePolicy" = 0;
  };
};

This configures Librewolf to enable WebGL, remember cookies and history by disabling privacy and security defaults.

Checklist

  • Change is backwards compatible.

  • Code formatted with ./format.

  • Code tested through nix-shell --pure tests -A run.all.

  • Test cases updated/added. See example.

  • Commit messages are formatted like

    {component}: {description}
    
    {long description}
    

    See CONTRIBUTING for more information and recent commit messages for examples.

  • If this PR adds a new module

    • Added myself as module maintainer. See example.

    • Added myself and the module files to .github/CODEOWNERS.

@onny onny requested a review from rycee as a code owner May 23, 2022 19:45
@onny onny marked this pull request as draft May 23, 2022 19:47
@onny onny changed the title [DRAFT] librewolf: init module librewolf: init module May 23, 2022
@onny onny marked this pull request as ready for review May 23, 2022 20:18
@onny onny force-pushed the librewolf branch 2 times, most recently from 37a5faf to 111d57f Compare May 24, 2022 11:27
@onny
Copy link
Contributor Author

onny commented May 28, 2022

@sumnerevans

@onny
Copy link
Contributor Author

onny commented Jun 2, 2022

@kubukoz

@onny
Copy link
Contributor Author

onny commented Jun 5, 2022

@somasis :)

@rycee
Copy link
Member

rycee commented Jun 26, 2022

Thanks! Added a few comments.

@onny onny force-pushed the librewolf branch 2 times, most recently from 473a102 to dcc85b6 Compare June 27, 2022 12:32
@onny onny requested a review from rycee June 27, 2022 12:32
@onny
Copy link
Contributor Author

onny commented Jun 27, 2022

Thank you @rycee, fixed the issues :)

Copy link
Member

@sumnerevans sumnerevans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, just noticed a couple other minor things.

.github/CODEOWNERS Outdated Show resolved Hide resolved
modules/programs/librewolf.nix Outdated Show resolved Hide resolved
@onny
Copy link
Contributor Author

onny commented Jul 7, 2022

Thank you @sumnerevans for the feedback :) Fixed it!

@rycee rycee merged commit 2c94b98 into nix-community:master Jul 13, 2022
@rycee
Copy link
Member

rycee commented Jul 13, 2022

Thanks! Merged to master now. Note, I made the module Linux only since the librewolf package in Nixpkgs doesn't seem to support Darwin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants