home-environment: fix evaluation error on undefined lang.base#3
Closed
dermetfan wants to merge 1 commit intonix-community:masterfrom
Closed
home-environment: fix evaluation error on undefined lang.base#3dermetfan wants to merge 1 commit intonix-community:masterfrom
lang.base#3dermetfan wants to merge 1 commit intonix-community:masterfrom
Conversation
Member
|
Many thanks again! I rebased the PR into master in fa73a7f. I think my original idea was that it wouldn't make much sense to set language options without having a base language. But if you want to maintain the system language and only change, e.g., the monetary language setting then of course the base has to be unset here. Good stuff :-) |
Member
|
By the way, I sent you a collaboration invite that you can accept if you'd like to be able to do direct commits. If you accept please keep the commit message format that has been used up to now and if you make non-trivial changes (I would consider this a trivial change) then please open a PR. |
Collaborator
Author
|
Thank you for the trust! I'll try my best when I come across an issue again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Triggered by
home.sessionVariableSetter = "pam";.