New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kitty: add shellIntegration #3759
kitty: add shellIntegration #3759
Conversation
647ca3a
to
0f3d3dc
Compare
0f3d3dc
to
c46f9b9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a bit confusing to have enable = true
, enable*Integration = true
and mode = "enabled"
. Can we simplify this?
Hmm. What if we get rid of |
Or alternatively, check if |
e84778d
to
bd0c528
Compare
If kitty does this automatically, why do we have to do it ourselves? |
It is just more robust, especially for more complex workflows:
|
0375173
to
4c86f23
Compare
Kitty provides integrations for bash, fish and zsh. The new programs.kitty.shellIntegration options allow the configuration of these integrations. See <https://sw.kovidgoyal.net/kitty/shell-integration> for more details. Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net>
4c86f23
to
721d953
Compare
Also, the way kitty does this is by modifying the bashrc at runtime which it can't do if the bashrc is managed by home manager. |
Kitty provides integrations for bash, fish and zsh. The new programs.kitty.shellIntegration options allow the configuration of these integrations. See <https://sw.kovidgoyal.net/kitty/shell-integration> for more details. Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net>
Kitty provides integrations for bash, fish and zsh. The new programs.kitty.shellIntegration options allow the configuration of these integrations. See <https://sw.kovidgoyal.net/kitty/shell-integration> for more details. Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net>
Kitty provides integrations for bash, fish and zsh. The new programs.kitty.shellIntegration options allow the configuration of these integrations. See <https://sw.kovidgoyal.net/kitty/shell-integration> for more details. Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net>
Kitty provides integrations for bash, fish and zsh. The new programs.kitty.shellIntegration options allow the configuration of these integrations. See <https://sw.kovidgoyal.net/kitty/shell-integration> for more details. Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net>
Description
Kitty provides integrations for bash, fish and zsh. The new programs.kitty.shellIntegration options allow the configuration of these integrations.
See https://sw.kovidgoyal.net/kitty/shell-integration for more details
Checklist
Change is backwards compatible.
Code formatted with
./format
.Code tested through
nix-shell --pure tests -A run.all
.Test cases updated/added. See example.
Commit messages are formatted like
See CONTRIBUTING for more information and recent commit messages for examples.
If this PR adds a new module
Added myself as module maintainer. See example.
Added myself and the module files to
.github/CODEOWNERS
.