Skip to content

broot: Add nushell integration#4714

Merged
dermetfan merged 1 commit intonix-community:masterfrom
takac:broot-nushell-integration
Dec 4, 2023
Merged

broot: Add nushell integration#4714
dermetfan merged 1 commit intonix-community:masterfrom
takac:broot-nushell-integration

Conversation

@takac
Copy link
Contributor

@takac takac commented Nov 29, 2023

Description

Add additional config flag enableNushellIntegration in broot.nix to setup broot/br for nushell.

Checklist

  • Change is backwards compatible.

  • Code formatted with ./format.

  • Code tested through nix-shell --pure tests -A run.all or nix develop --ignore-environment .#all using Flakes.

  • Test cases updated/added. See example.

  • Commit messages are formatted like

    {component}: {description}
    
    {long description}
    

    See CONTRIBUTING for more information and recent commit messages for examples.

Maintainer CC

@aheaume @dermetfan

Add additional config flag `enableNushellIntegration` in broot.nix to
setup broot/br for nushell.
@takac takac force-pushed the broot-nushell-integration branch from 5b1d423 to 99af675 Compare November 29, 2023 14:23
@takac takac requested a review from dermetfan December 1, 2023 10:26
@dermetfan dermetfan self-assigned this Dec 1, 2023
@dermetfan
Copy link
Collaborator

dermetfan commented Dec 1, 2023

With Nushell 0.87.0 and broot 1.27.0 (which are currently in 23.11) I get this error message on startup:

Error:   × Deprecated command
    ╭─[/nix/store/gdwnbsz8wxrgg6iy2prraj3d6yill27p-br.nushell:10:1]
 10 │ # See https://dystroy.org/broot/install-br/
 11 │ def-env br [
    · ───┬───
    ·    ╰── `def-env` is deprecated and will be removed in 0.88.
 12 │     --cmd(-c): string               # Semicolon separated commands to execute
    ╰────
  help: Use `def --env` instead

The script still works so this is not a hard error but certainly ugly.

However, I believe it is still the right decision to merge for the following reasons:

  1. This is an issue with broot. They will likely fix this and we won't have to change any code, so the problem will disappear by itself.
  2. programs.zoxide.enableNushellIntegration has the same issue and is also enabled by default.
  3. While the default is to enable nushell integration, users are still free to disable it.

I will merge in the coming days if no one raises concerns.

@dermetfan dermetfan merged commit 948703f into nix-community:master Dec 4, 2023
@dermetfan
Copy link
Collaborator

Thanks for your contribution!

SimSaladin added a commit to SimSaladin/home-manager that referenced this pull request Dec 19, 2023
* upstream/master: (227 commits)
  home-manager: sort list packages output
  docs: set the manual version to "24.05 (unstable)"
  home-manager: improve nix profile detection
  docs: fix broken link text
  docs: fix link texts in release notes
  gtk: fix GTK 4 theme being ignored
  fish: Fix babelization of hm-session-vars
  docs: add considerate as maintainer
  docs: use .xhtml for appendices
  docs: add release-notes as appendix
  yazi: pass additional args to ya alias
  hyprland: mark plugin setting as important
  flake: add packages for tests
  hyprland: improve config reload
  flake.lock: Update
  ssh: add addKeysToAgent option
  awscli: only write config files when not empty
  docs: fix nix-darwin module configuration example
  msmtp: add configurable package
  Translate using Weblate (Portuguese)
  Translate using Weblate (Russian)
  Translate using Weblate (Russian)
  Translate using Weblate (Russian)
  Translate using Weblate (Russian)
  Translate using Weblate (Catalan)
  Translate using Weblate (Russian)
  Translate using Weblate (Russian)
  hyprland: add option sourceFirst
  ci: bump cachix/cachix-action from 12 to 13
  caffeine: remove ProtectHome service option
  docs: fix broken links in README
  docs: use relative paths to static resources
  Translate using Weblate (Czech)
  docs: apply nixfmt
  docs: rename generated manual to `index.xhtml`
  docs: fix syntax highlighting
  docs: render DESCRIPTION and OPTIONS headings
  docs: replace `console` language with `shell`
  docs: update nmd version
  docs: extend home-configuration.nix header
  docs: include 3rd-party part
  docs: this is the `home-manager` manual
  docs: fix note blocks
  docs: no justification in home-manager manpage
  docs: use nixos-render-docs
  docs: update manual to refer to 23.11
  docs: update paths to make manual tests pass
  docs: add htmlOpenTool to manual
  docs: add home-manager manpage
  docs: render without deprecated optionsDocBook
  firefox: fix folders not showing in toolbar
  broot: Add nushell integration (nix-community#4714)
  Translate using Weblate (Dutch)
  Translate using Weblate (Italian)
  Translate using Weblate (Russian)
  flake.lock: Update
  swayidle: add systemd suspend to example
  swayidle: daemonize swaylock in example configuration
  Translate using Weblate (Russian)
  Translate using Weblate (Russian)
  Translate using Weblate (Portuguese (Brazil))
  home-manager: add 24.05 as valid state version
  signaturepdf: add service
  flake.lock: Update
  yazi: update shell integrations and docs
  fish: support flexible abbreviations
  home-manager: set unstable release to 24.05
  home-manager: set stable release to 23.11
  bat: support boolean flags in config
  ruff: add module
  picom: use getExe instead of hardcoded binary
  qt: fix `qt.platformTheme = "gtk3"`
  zsh: allow enabling syntax highlighters (nix-community#4360)
  qt: fix basic usage when just `qt.enable = true` is set
  home-manager: improve comment in example configuration
  flake.lock: Update
  Translate using Weblate (French)
  firefox: add support for specifying policies (nix-community#4626)
  Translate using Weblate (French)
  Translate using Weblate (Turkish)
  Translate using Weblate (Italian)
  openstackclient: add module (nix-community#4530)
  firefox: support setting a separate default search engine in private browsing (nix-community#4114)
  swayidle: always restart systemd unit on failure
  firefox: minor documentation fix
  firefox: add finalPackage read-only option
  k9s: add aliases, plugins, views
  systemd: avoid creating an empty user.conf
  emacs: Fix socket activation
  emacs: Remove obsolete socket file workaround
  firefox: add container support
  firefox: refactor duplicate profile ID detection
  systemd: add settings option (nix-community#4276)
  home-cursor: fix typo in XDG data directory link
  swayr: add module (nix-community#4322)
  thefuck: add fish integration (nix-community#4535)
  clipmenu: set Environment to a list
  granted: add module
  borgmatic: preparing upcoming borgmatic change
  k9s: add hotkey option (nix-community#4617)
  zsh: made ZDOTDIR export to the shell (nix-community#4619)
  services.swayidle: change target to generic session (nix-community#3913)
  wezterm: remove automatic config reload call
  aerc: fix config paths on darwin
  hyprland: add tray.target
  helix: add extraPackages option
  sxhkd: set scope OOMPolicy to continue
  cava: add module
  cbatticon: Add support for batteryId
  qt: support gtk3 platform theme
  qt: allow usage without setting platformTheme
  aerc: fix config paths on darwin
  readme: major cleanup
  exa: add aliases to nushell
  docs: fix option name
  qt: use sessionVariablesExtra to export QT_PLUGIN_PATH/QML2_IMPORT_PATH
  qt: simplify style.name mappings
  qt: add qgnomeplatform-qt6 when platformTheme is set to gnome
  qt: add support for platformTheme lxqt
  Translate using Weblate (Portuguese)
  Translate using Weblate (Lithuanian)
  Translate using Weblate (Turkish)
  qutebrowser: add greasemonkey userscript option
  flake.lock: Update
  qt: add style mappings for Qt 6
  qt: workaround issue when i18n.inputMethod.enabled = 'fcitx5'
  qt: remove top-level `with lib`
  qt: export QT_PLUGIN_PATH/QML2_IMPORT_PATH
  ...
fufexan pushed a commit to fufexan/home-manager that referenced this pull request Feb 24, 2024
Add additional config flag `enableNushellIntegration` in broot.nix to
setup broot/br for nushell.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants