broot: get rid of IFD - #6723
Merged
Merged
Conversation
ambroisie
approved these changes
Apr 1, 2025
ambroisie
left a comment
ambroisie
left a comment
Contributor
There was a problem hiding this comment.
Small nit, would approve as-is otherwise.
dermetfan
added a commit
to dermetfan/home-manager
that referenced
this pull request
Apr 5, 2025
(cherry picked from commit f4d9d1e)
dermetfan
added a commit
to dermetfan/home-manager
that referenced
this pull request
Apr 5, 2025
(cherry picked from commit f4d9d1e)
khaneliman
pushed a commit
that referenced
this pull request
Apr 8, 2025
(cherry picked from commit f4d9d1e)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This gets rid of IFD in the broot module.
This is backwards incompatible insofar as that when referencing
config.programs.broot.settingsat eval time, the default values are no longer merged in. However, I don't think many users depend on that, if any.closes #6616
Checklist
Change is backwards compatible.
Code formatted with
./format.Code tested through
nix-shell --pure tests -A run.allor
nix build --reference-lock-file flake.lock ./tests#test-allusing Flakes.Test cases updated/added. See example.
Commit messages are formatted like
Maintainer CC
@aheaume