parcellite: fix GTK theme #932
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rycee
reviewed
Dec 1, 2019
|
Yeah, seems these could safely removed. As I mentioned in the line comment I think you can remove
|
This also fixes that the `gtk.theme` option was not picked up due to hardcoded XDG_DATA_DIRS.
dermetfan
force-pushed
the
fix/parcellite-gtk-theme
branch
from
6480bef
to
fba3331
Compare
|
Nice, I kept it to err on the safe side, but this is cleaner. I was going to merge this myself to spare you a pointless review, but now I'm uncertain because the Travis build failed. It seems that's not an issue to address in this PR though. |
|
Yeah, the CI error is unrelated. I'm not certain what it is about but asked in the #nixos IRC channel a while ago, hopefully somebody knows. |
|
I rebased the commit to master in fdd65e5. Note, I wrapped the commit message to make it a bit less wide. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
gtk.themeoption is not picked up due to hardcodedXDG_DATA_DIRS.Since icons do show up without this environment variable in the service unit I don't think it is necessary (anymore). According to the
basictest we hopeXDG_DATA_DIRSis set anyway.cc @gleber