Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build0*: move into /hosts #597

Merged
merged 1 commit into from Jun 1, 2023
Merged

build0*: move into /hosts #597

merged 1 commit into from Jun 1, 2023

Conversation

zowoq
Copy link
Contributor

@zowoq zowoq commented May 18, 2023 •
edited

e.g.

hosts
  darwin02
  build01
  build02
  build03
  build04

@zimbatm
Copy link
Member

zimbatm commented May 18, 2023

I don't get what problem it resolves since the machine name already gives a hint of what type of system it is.

@zowoq
Copy link
Contributor Author

zowoq commented May 19, 2023 •
edited

Forgot to say why, sorry. Would like to push the machine dirs down a level instead of keeping them all in the repo root.

Both darwin and nixos in one directory could work as well?

system
  darwin02
  build01
  build02
  build03
  build04

Maybe host instead of system as that's what we use currently in tasks.py?

@zowoq zowoq changed the title build0*: move into /nixos build0*: move into /hosts May 25, 2023
@zowoq zowoq force-pushed the build-refactor branch 3 times, most recently from a6d78b0 to b6eab95 Compare May 26, 2023 23:49
@zowoq zowoq marked this pull request as ready for review May 31, 2023 13:33
@zimbatm
Copy link
Member

zimbatm commented May 31, 2023

Ok, it looks like the change is mostly a matter of preference of categorization. It doesn't solve a technical problem.

@zowoq
Copy link
Contributor Author

zowoq commented Jun 1, 2023

No, it doesn't solve a technical problem, just easier to work with as we add more hardware.

@zowoq zowoq added this pull request to the merge queue Jun 1, 2023
Merged via the queue into master with commit 5e5678e Jun 1, 2023
3 checks passed
@zowoq zowoq deleted the build-refactor branch June 1, 2023 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zimbatm zimbatm zimbatm approved these changes

Assignees
No one assigned
Labels
sops secrets
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zowoq @zimbatm