services/buildkite-agents: support multi-tags#1439
Merged
Conversation
Samasaur1
requested changes
May 11, 2025
Samasaur1
left a comment
Samasaur1
left a comment
Member
There was a problem hiding this comment.
Content looks good to me. If you can amend your commit message and the PR title to be services/buildkite-agents: support multi-tags, I'll merge this PR
dermetfan
force-pushed
the
buildkite-multi-tags
branch
from
May 12, 2025 10:59
7884fcb to
8464443
Compare
dermetfan
changed the title
Samasaur1
approved these changes
May 12, 2025
Samasaur1
left a comment
Samasaur1
left a comment
Member
There was a problem hiding this comment.
Thanks for the contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is essentially a port of NixOS/nixpkgs#120209.
#653 already used the correct option type, just the implementation was lacking.