Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upsys/stat: implement mkdirat #1084
Conversation
kevinwern
force-pushed the
kevinwern:feature/implement-mkdirat
branch
from
7efc042
to
515bee4
kevinwern
force-pushed the
kevinwern:feature/implement-mkdirat
branch
from
515bee4
to
a844ff0
|
You need to wrap that long line and fix the CHANGELOG. Otherwise, it all looks good. |
This comment has been minimized.
This comment has been minimized.
|
Switched the error condition to ENOTDIR because I suspected the FreeBSD build was failing due to |
kevinwern
force-pushed the
kevinwern:feature/implement-mkdirat
branch
from
a844ff0
to
aab61a4
kevinwern
force-pushed the
kevinwern:feature/implement-mkdirat
branch
from
aab61a4
to
c006491
This comment has been minimized.
This comment has been minimized.
|
Rebased again...just leaving a comment because I forget if GH sends notifications for force pushes. |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Jun 16, 2019
1084: sys/stat: implement mkdirat r=asomers a=kevinwern See: https://github.com/CraneStation/wasi-common/issues/16 https://linux.die.net/man/2/mkdirat My first contribution to this repo. Tests were probably overkill... Also, out of curiosity, is there any reason why `mkdir` is located in `unistd`? The documentation I read mentioned the function definition also being located in `sys/stat.h`. Co-authored-by: Kevin Wern <kevin.m.wern@gmail.com>
This comment has been minimized.
This comment has been minimized.
Build succeeded
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
kevinwern commentedJun 10, 2019
See: https://github.com/CraneStation/wasi-common/issues/16
https://linux.die.net/man/2/mkdirat
My first contribution to this repo. Tests were probably overkill...
Also, out of curiosity, is there any reason why
mkdiris located inunistd? The documentation I read mentioned the function definition also being located insys/stat.h.