Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a passwd field to Group #1338

Merged
merged 1 commit into from Feb 7, 2021
Merged

Conversation

blinsay
Copy link
Contributor

@blinsay blinsay commented Nov 22, 2020

Adds a passwd field to unistd::Group. The gr_passwd field exists on libc::group and wasn't exposed.

I didn't see tests for from(libc:group) for either User or Password. Let me know if there are other tests I should add!

Copy link
Member

@asomers asomers left a comment

What systems actually use the group password? I for one have never seen it actually used.

@blinsay
Copy link
Contributor Author

blinsay commented Nov 29, 2020

I haven't actually seen it used either, but I'm working on a backend to nscd and glibc seems to expect a group password as part of the response.

Given that passwd is mentioned in the man page, is there a reason to not include it here?

@blinsay
Copy link
Contributor Author

blinsay commented Jan 16, 2021

@asomers given this any more thought?

@asomers
Copy link
Member

asomers commented Jan 31, 2021

Yes, I think it seems reasonable. But could you add a CHANGELOG entry and rebase?

@blinsay
Copy link
Contributor Author

blinsay commented Feb 7, 2021

Done! Sorry for the delay.

asomers
asomers approved these changes Feb 7, 2021
Copy link
Member

@asomers asomers left a comment

bors r+

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants