Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow sockaddr_ll size mismatch #1395

Merged
merged 1 commit into from Mar 6, 2021
Merged

Allow sockaddr_ll size mismatch #1395

merged 1 commit into from Mar 6, 2021

Conversation

internetionals
Copy link
Contributor

Apparently the Linux kernel can return smaller sizes when the value in
the last element of sockaddr_ll (sll_addr) is smaller than the
declared size of that field.

Copy link
Member

@asomers asomers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting. Did you see this happen on Ethernet, or with some other link layer?

Also, you'll have to rebase after #1399 merges.

@internetionals
Copy link
Contributor Author

Interesting. Did you see this happen on Ethernet, or with some other link layer?

I saw this happen on Ethernet. I don't recall on which system I tested the original, might have been some virtual fabric.

Also, you'll have to rebase after #1399 merges.

Ok

Apparently the Linux kernel can return smaller sizes when the value in
the last element of sockaddr_ll (`sll_addr`) is smaller than the
declared size of that field.
Copy link
Member

@asomers asomers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

@bors bors bot merged commit 2d36e3a into nix-rust:master Mar 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants