Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat #1733: add F_GET_SEALS and F_ADD_SEALS on FreeBSD #1782

Merged

Conversation

SteveLauC
Copy link
Member

Closes #1733

Copy link
Member

@asomers asomers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. However, I'm not going to merge it yet because CI will fail (see serde-rs/serde#2255).

@SteveLauC
Copy link
Member Author

LGTM. However, I'm not going to merge it yet because CI will fail (see serde-rs/serde#2255).

That's fine, let's wait:)

@asomers
Copy link
Member

asomers commented Aug 12, 2022

rebase please

@SteveLauC SteveLauC force-pushed the issue1733-make-F_SEAL-available-on-FreeBSD branch from 22faed4 to 44b1ad3 Compare August 12, 2022 01:39
@SteveLauC
Copy link
Member Author

@asomers This is ready to merge

@rtzoeller
Copy link
Collaborator

@SteveLauC it looks like there are three commits modifying the same lines - can you squash them?

@SteveLauC SteveLauC force-pushed the issue1733-make-F_SEAL-available-on-FreeBSD branch from 44b1ad3 to 29fe67d Compare August 12, 2022 04:55
@SteveLauC
Copy link
Member Author

@rtzoeller sure thing! done.

@rtzoeller
Copy link
Collaborator

bors r+

@bors bors bot merged commit 5252f7e into nix-rust:master Aug 12, 2022
@SteveLauC SteveLauC deleted the issue1733-make-F_SEAL-available-on-FreeBSD branch August 12, 2022 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fcntl F_SEAL not available on FreeBSD
3 participants