Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated items #1785

Merged
merged 5 commits into from
Aug 12, 2022
Merged

Remove deprecated items #1785

merged 5 commits into from
Aug 12, 2022

Conversation

SteveLauC
Copy link
Member

What this pr does

  1. Convert assert!(x == y) to assert_eq!(x, y)
  2. Convert assert!(x != y) to assert_ne!(x, y)
  3. Add .unwrap() to unused Result/Option (in code comments)
  4. Convert std::ixx::MAX to ixx::MAX
  5. Convert Box<Trait> to Box<dyn Trait>

@SteveLauC
Copy link
Member Author

Almost all the CI tests failed.

error: failed to compile `cargo-hack v0.5.14`, intermediate artifacts can be found at `/tmp/cargo-installtsdEE2`

Caused by:
  failed to parse manifest at `/usr/local/cargo/registry/src/github.com-1ecc6299db9ec823/serde-1.0.143/Cargo.toml`

Caused by:
  feature `resolver` is required

  this Cargo does not support nightly features, but if you
  switch to nightly channel you can add
  `cargo-features = ["resolver"]` to enable this feature

Exit status: 101

It seems to be related to the Rust toolchain

asomers
asomers approved these changes Aug 11, 2022
View reviewed changes
Copy link
Member

@asomers asomers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Was this suggested by some automated tool?
CI will be broken until serde publishes a new crate.

@SteveLauC
Copy link
Member Author

Was this suggested by some automated tool?

Yep, by Intellij Rust

CI will be broken until serde publishes a new crate.

That's fine:)

@rtzoeller rtzoeller mentioned this pull request Aug 11, 2022
Merged
@asomers asomers added this to the 0.25.0 milestone Aug 11, 2022
@asomers
Copy link
Member

asomers commented Aug 12, 2022

rebase please

asomers
asomers approved these changes Aug 12, 2022
View reviewed changes
Copy link
Member

@asomers asomers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

@bors
Copy link
Contributor

bors bot commented Aug 12, 2022

Build succeeded:

@bors bors bot merged commit a9861d8 into nix-rust:master Aug 12, 2022
@SteveLauC SteveLauC deleted the remove-deprecated-items branch August 12, 2022 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asomers asomers asomers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.25.0
Development

Successfully merging this pull request may close these issues.
2 participants
@SteveLauC @asomers