Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make preadv take immutable slice of IoVecs #914

Merged
merged 1 commit into from Jul 3, 2018
Merged

Conversation

@farnoy
Copy link
Contributor

@farnoy farnoy commented Jun 11, 2018

fixes #913

I filled in the CHANGELOG, but I see that it usually links to PRs and not issues, do you want me to change it or remove and leave for you to describe?

This change seems to be strictly backwards-compatible, I didn't have to change the test for it to work.

Copy link
Member

@asomers asomers left a comment

This looks fine to me. It just needs three changes to the CHANGELOG:

  1. Reference the PR, not the issue.
  2. Wrap to 80 columns.
  3. Since it's backwards compatible, put it in the "Fixed" section instead of "Changed".
@farnoy farnoy force-pushed the farnoy:master branch from c54ff05 to c39859c Jul 3, 2018
@farnoy
Copy link
Contributor Author

@farnoy farnoy commented Jul 3, 2018

Should be fine now ♻️

@asomers
Copy link
Member

@asomers asomers commented Jul 3, 2018

Not quite. There's a typo in the new changelog entry.

@farnoy farnoy force-pushed the farnoy:master branch from c39859c to db4ea2b Jul 3, 2018
@farnoy
Copy link
Contributor Author

@farnoy farnoy commented Jul 3, 2018

👍

@asomers
asomers approved these changes Jul 3, 2018
@asomers
Copy link
Member

@asomers asomers commented Jul 3, 2018

bors r+

bors bot added a commit that referenced this pull request Jul 3, 2018
Merge #914
914: Make preadv take immutable slice of IoVecs r=asomers a=farnoy

fixes #913

I filled in the CHANGELOG, but I see that it usually links to PRs and not issues, do you want me to change it or remove and leave for you to describe?

This change seems to be strictly backwards-compatible, I didn't have to change the test for it to work.

Co-authored-by: Jakub Okoński <jakub@okonski.org>
@bors bors bot merged commit db4ea2b into nix-rust:master Jul 3, 2018
4 checks passed
4 checks passed
bors Build succeeded
Details
buildbot/nix-rust/nix amd64_fbsd11 Build done.
Details
buildbot/nix-rust/nix i386_fbsd11 Build done.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants