Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

socket: add AF_UNSPEC to AddressFamily #948

Merged
merged 1 commit into from Oct 15, 2018
Merged

Conversation

@levex
Copy link
Contributor

@levex levex commented Oct 6, 2018

Hi!

I work on a crate where it would make sense to use AF_UNSPEC in place of AF_INET, since that's the API most bridge libraries use. Unfortunately, it seems that nix is missing a representation for AF_UNSPEC. This PR adds Unspec to AddressFamily, so we can now represent AF_UNSPEC.

@asomers
Copy link
Member

@asomers asomers commented Oct 12, 2018

Sure, this looks fine. Just add an entry to CHANGELOG and I'll merge it.

Signed-off-by: Levente Kurusa <lkurusa@acm.org>
@levex levex force-pushed the levex:add-af-unspec branch from 4567832 to a75bcfe Oct 15, 2018
@levex
Copy link
Contributor Author

@levex levex commented Oct 15, 2018

@asomers great! I've added an entry to the CHANGELOG.

@asomers
Copy link
Member

@asomers asomers commented Oct 15, 2018

bors r+

bors bot added a commit that referenced this pull request Oct 15, 2018
Merge #948
948: socket: add AF_UNSPEC to AddressFamily r=asomers a=levex

Hi!

I work on a [crate](https://github.com/levex/network-bridge-rs) where it would make sense to use `AF_UNSPEC` in place of `AF_INET`, since that's the API most bridge libraries use. Unfortunately, it seems that `nix` is missing a representation for `AF_UNSPEC`. This PR adds `Unspec` to `AddressFamily`, so we can now represent `AF_UNSPEC`.

Co-authored-by: Levente Kurusa <lkurusa@acm.org>
@bors bors bot merged commit a75bcfe into nix-rust:master Oct 15, 2018
4 checks passed
4 checks passed
bors Build succeeded
Details
buildbot/nix-rust/nix amd64_fbsd11 Build done.
Details
buildbot/nix-rust/nix i386_fbsd11 Build done.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants