Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sys::stat::mode_t public #954

Merged
merged 1 commit into from Oct 17, 2018
Merged

Make sys::stat::mode_t public #954

merged 1 commit into from Oct 17, 2018

Conversation

@jmmv
Copy link
Contributor

@jmmv jmmv commented Oct 17, 2018

This allows using e.g. sys::stat::Mode::from_bits() without having to
pull the mode_t type from libc (which is ugly if a project is trying
to use nix exclusively to avoid libc's unsafety).

This change mimics dev_t which was already exposed as public.

This allows using e.g. sys::stat::Mode::from_bits() without having to
pull the mode_t type from libc (which is ugly if a project is trying
to use nix exclusively to avoid libc's unsafety).

This change mimics dev_t which was already exposed as public.
Copy link
Member

@asomers asomers left a comment

LGTM.

bors r+

bors bot added a commit that referenced this pull request Oct 17, 2018
Merge #954
954: Make sys::stat::mode_t public r=asomers a=jmmv

This allows using e.g. sys::stat::Mode::from_bits() without having to
pull the mode_t type from libc (which is ugly if a project is trying
to use nix exclusively to avoid libc's unsafety).

This change mimics dev_t which was already exposed as public.

Co-authored-by: Julio Merino <julio@meroh.net>
@bors bors bot merged commit ea6ed5a into nix-rust:master Oct 17, 2018
4 checks passed
4 checks passed
bors Build succeeded
Details
buildbot/nix-rust/nix amd64_fbsd11 Build done.
Details
buildbot/nix-rust/nix i386_fbsd11 Build done.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jmmv jmmv deleted the jmmv:mode_t branch Oct 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants