Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sync (fix #959) #961

Merged
merged 1 commit into from Nov 2, 2018
Merged

Add sync (fix #959) #961

merged 1 commit into from Nov 2, 2018

Conversation

@r-darwish
Copy link
Contributor

@r-darwish r-darwish commented Nov 1, 2018

No description provided.

Copy link
Member

@asomers asomers left a comment

You'll need to add a CHANGELOG entry for this. Also, you don't need #[inline]. The compiler will figure that out for any applications using LTO.

@r-darwish
Copy link
Contributor Author

@r-darwish r-darwish commented Nov 1, 2018

@asomers done. Thanks for the quick review.

@asomers
asomers approved these changes Nov 2, 2018
Copy link
Member

@asomers asomers left a comment

LGTM.

bors r+

bors bot added a commit that referenced this pull request Nov 2, 2018
Merge #961
961: Add sync (fix #959) r=asomers a=r-darwish



Co-authored-by: Roey Darwish Dror <roey.ghost@gmail.com>
@bors bors bot merged commit a37f845 into nix-rust:master Nov 2, 2018
4 checks passed
4 checks passed
bors Build succeeded
Details
buildbot/nix-rust/nix amd64_fbsd11 Build done.
Details
buildbot/nix-rust/nix i386_fbsd11 Build done.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants