Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add execvpe support, conditional on platform #975

Merged
merged 1 commit into from Nov 23, 2018
Merged

Add execvpe support, conditional on platform #975

merged 1 commit into from Nov 23, 2018

Conversation

@F1rst-Unicorn
Copy link
Contributor

@F1rst-Unicorn F1rst-Unicorn commented Nov 18, 2018

This closes #682

Copy link
Member

@asomers asomers left a comment

This PR looks pretty good. I just have a few minor requests about the documentation.

src/unistd.rs Outdated Show resolved Hide resolved
src/unistd.rs Outdated Show resolved Hide resolved
src/unistd.rs Outdated Show resolved Hide resolved
@F1rst-Unicorn
Copy link
Contributor Author

@F1rst-Unicorn F1rst-Unicorn commented Nov 18, 2018

I adapted your change requests (not sure whether I shall also "Resolve conversation"...)

Copy link
Member

@asomers asomers left a comment

bors r+

bors bot added a commit that referenced this pull request Nov 23, 2018
Merge #975
975: Add execvpe support, conditional on platform r=asomers a=F1rst-Unicorn

This closes #682 

Co-authored-by: F1rst-Unicorn <f1rst_unicorn@njsm.de>
@bors bors bot merged commit 35c0d63 into nix-rust:master Nov 23, 2018
4 checks passed
4 checks passed
bors Build succeeded
Details
buildbot/nix-rust/nix amd64_fbsd11 Build done.
Details
buildbot/nix-rust/nix i386_fbsd11 Build done.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants