Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ruby: reproducible #118551

Merged
merged 1 commit into from Apr 6, 2021
Merged

ruby: reproducible #118551

merged 1 commit into from Apr 6, 2021

Conversation

tomberek
Copy link
Contributor

@tomberek tomberek commented Apr 5, 2021 •
edited

Motivation for this change

https://r13y.com/diff/fdf835d046bf03f72960cb4abf95821e9178bae26817e15753eaf3f166df6ff7-36caf8c832e64c8534b4c619d716d117b0963183f83d969b617f8ca498930821.html

Prior art:
#101655
c3357d2

Things done

Generated Makefile's were nested deeper than the existing rm would be
able to remove.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from zimbatm, manveru, nixy, Ma27 and marsam April 5, 2021 04:37
@tomberek
Copy link
Contributor Author

tomberek commented Apr 5, 2021

Result of nixpkgs-review pr 118551 run on x86_64-linux 1

16 packages built:
  • rubyPackages.actioncable
  • rubyPackages.actionmailbox
  • rubyPackages.actionmailer
  • rubyPackages.actionpack
  • rubyPackages.actiontext
  • rubyPackages.actionview
  • rubyPackages.activejob
  • rubyPackages.activemodel
  • rubyPackages.activerecord
  • rubyPackages.activestorage
  • rubyPackages.activesupport
  • rubyPackages.addressable
  • rubyPackages.ast
  • rubyPackages.atk
  • rubyPackages.atomos
  • rubyPackages.awesome_print

@tomberek tomberek marked this pull request as ready for review April 5, 2021 05:39
@tomberek tomberek changed the base branch from master to staging April 5, 2021 05:40
@zimbatm
Copy link
Member

zimbatm commented Apr 5, 2021

Nice catch!

@tomberek
ruby: reproducible
70752b8 
Generated Makefile's were nested deeper than the existing rm would be
able to remove.
@ofborg ofborg bot requested a review from zimbatm April 5, 2021 16:15
@tomberek tomberek merged commit a10183d into NixOS:staging Apr 6, 2021
21 checks passed
@tomberek tomberek deleted the ruby_reproduce branch April 6, 2021 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manveru manveru

@nixy nixy

@Ma27 Ma27

@marsam marsam

@zimbatm zimbatm

Assignees
No one assigned
Labels
6.topic: ruby 10.rebuild-darwin: 501+ 10.rebuild-darwin: 2501-5000 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tomberek @zimbatm