Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename key_slope to feat_lm ? #92

Open
njtierney opened this issue Jun 16, 2020 · 2 comments
Open

rename key_slope to feat_lm ? #92

njtierney opened this issue Jun 16, 2020 · 2 comments

Comments

@njtierney
Copy link
Owner

As suggested by @MilesMcBain - this will make it easier to find, and is more in line with the other names.
@njtierney
Copy link
Owner Author

Things to consider

  • Does this behave similar to other feat functions?
  • Expectations for input

@MilesMcBain
Copy link

MilesMcBain commented Jun 16, 2020 •
edited

Yeah I was definitely looking for something similar to the other feat functions. It would be a little unusual in that it needs a formula.

Maybe the formula could default to .var ~ index?

Where .var is the column that is supplied via features api and index is the tsibble index. Can tsibbles have multi-column indexes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@njtierney @MilesMcBain