New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename impute_below to impute_below_all #159

Closed
njtierney opened this Issue May 4, 2018 · 3 comments

Comments

Projects
1 participant
@njtierney
Owner

njtierney commented May 4, 2018

impute_below would work on a vector - which makes it an alias to shadow_shift, which is kind of annoying, but is just due to the evolution of the package.

@njtierney njtierney modified the milestones: V0.3.0, V0.4.0 Jun 5, 2018

@njtierney

This comment has been minimized.

Show comment
Hide comment
@njtierney

njtierney Jun 5, 2018

Owner

This is not mission critical at the moment, will move to Version 0.4.0

Owner

njtierney commented Jun 5, 2018

This is not mission critical at the moment, will move to Version 0.4.0

@njtierney

This comment has been minimized.

Show comment
Hide comment
@njtierney

njtierney Aug 12, 2018

Owner

Current progress on this is on the branch impute-below-all

Looking at this now, it will make sense to soft-deprecate shadow_shift in the next version 0.5.0, and then remove it completely later in the piece. I think that it is more useful to think of impute_below as an imputation, rather than shadow_shift as a special operation.

Owner

njtierney commented Aug 12, 2018

Current progress on this is on the branch impute-below-all

Looking at this now, it will make sense to soft-deprecate shadow_shift in the next version 0.5.0, and then remove it completely later in the piece. I think that it is more useful to think of impute_below as an imputation, rather than shadow_shift as a special operation.

@njtierney

This comment has been minimized.

Show comment
Hide comment
@njtierney

njtierney Aug 12, 2018

Owner

Need to re-write the tests for impute_below as it used to operate on a dataframe

Owner

njtierney commented Aug 12, 2018

Need to re-write the tests for impute_below as it used to operate on a dataframe

njtierney added a commit that referenced this issue Aug 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment