Skip to content

/ naniar

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct 'fill' aesthetic behavior in geom_miss_point() #137 #144

Merged
merged 1 commit into from Apr 17, 2018
Merged

Correct 'fill' aesthetic behavior in geom_miss_point() #137 #144

merged 1 commit into from Apr 17, 2018

Conversation

@seasmith
Copy link
Contributor

@seasmith seasmith commented Apr 13, 2018

Description

Using fill = var now works as expected in geom_miss_point()

Related Issue

fix #137

Tests

No tests included
@seasmith
Correct 'fill' aesthetic behavior in geom_miss_point() #137
Loading status checks…
89a9f99
@njtierney njtierney merged commit 0250b21 into njtierney:master Apr 17, 2018
4 checks passed
4 checks passed
codecov/patch Coverage not affected when comparing 26219fc...89a9f99
Details
codecov/project 86.38% remains the same compared to 26219fc
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@njtierney
Copy link
Owner

@njtierney njtierney commented Apr 17, 2018

Wonderful, thank you!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

inherit mapping in geom_miss_point
2 participants
@seasmith @njtierney
You can’t perform that action at this time.