Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use nrow argument in new_tibble() #220

Merged
merged 1 commit into from Nov 16, 2018
Merged

Conversation

@krlmlr
Copy link
Contributor

@krlmlr krlmlr commented Nov 15, 2018

This is required for the upcoming tibble 2.0.0 release.

I couldn't run the vdiffr tests.

CC @jennybc.

@njtierney
Copy link
Owner

@njtierney njtierney commented Nov 16, 2018

Awesome, thank you, Kirill! :)

@njtierney njtierney merged commit 29889fe into njtierney:master Nov 16, 2018
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@krlmlr krlmlr deleted the krlmlr:f-tibble-dev branch Nov 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.