Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installation failing in 2018.03 #46

Closed
JJ opened this issue Apr 10, 2018 · 3 comments
Closed

Installation failing in 2018.03 #46

JJ opened this issue Apr 10, 2018 · 3 comments

Comments

@JJ
Copy link
Contributor

JJ commented Apr 10, 2018

That would be Ubuntu, with this error:

===> Testing: Data::Dump::Tree:ver<1.8.0>:auth<github:nkh>
Cannot instantiate a native type
  in block <unit> at t/48_type_NativeCall.t line 45

@coke
Copy link

coke commented Apr 10, 2018

Looks like the code this test is relying on changed here:

rakudo/rakudo@e0af68a

Bisect log shows the change here:

https://gist.github.com/Whateverable/9768d709bd427e644e2e1e8b9862008c

For a while, it was deprecated, and the bisect log shows the new syntax:

Deprecated since v2017.09.403, will be removed with release v2018.01!
Please use (my num64 $ = 888e0) instead.

@coke
Copy link

coke commented Apr 10, 2018

This allows the test to pass:

diff --git a/t/48_type_NativeCall.t b/t/48_type_NativeCall.t
index 65f4aa6..7afda58 100644
--- a/t/48_type_NativeCall.t
+++ b/t/48_type_NativeCall.t
@@ -42,7 +42,7 @@ class MyStruct is repr('CStruct') {
 }

 my $mystruct = MyStruct.new ;
-$mystruct.point.x = num64.new(888e0)  ;
+$mystruct.point.x = (my num64 $ = 888e0);

 $dump = $d.ddt: :get, $mystruct ;
 is $dump.lines.elems, 5, '5 lines' or diag $dump ;

@coke
Copy link

coke commented Apr 10, 2018

See also: #44 and #42

@nkh nkh closed this as completed in 60962c8 Dec 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants