Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Report exception to client in WbCdxApi #84

Closed
ato opened this issue May 18, 2020 · 2 comments
Closed

Report exception to client in WbCdxApi #84

ato opened this issue May 18, 2020 · 2 comments

Comments

@ato
Copy link
Member

ato commented May 18, 2020

At the moment if a WbCdxApi query throws an exception the query results are truncated. While we can't switch status codes as we've already returned the header and are streaming results we could print a message so its at least obvious to humans that something's gone wrong. We could also maybe use chunked-encoding and close early although some http clients might still not treat that as an error.
@galgeek galgeek mentioned this issue Jul 17, 2020
Merged
@galgeek
Copy link
Contributor

galgeek commented Jul 17, 2020

Is there a good way to report an exception to all clients?

Logging the error on the server would be helpful. PR #86 would be a minimal fix, I think.

@ato
Copy link
Member Author

ato commented Jul 17, 2020

Returning an intentionally invalid line might be the best option I guess

@galgeek galgeek mentioned this issue Jul 19, 2020
Merged
@ato ato closed this as completed Jul 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ato @galgeek