Minor lint fixes and typos #4
Conversation
|
I thought I'd raise this quick PR to check if this fork is being maintained / welcoming development? I'm interested in making some improvements here because I'm trying to run a fluxbb import to discourse which uses this code, and I'm seeing some issues / missing features. I'm not clear why discourse uses this fork and not the rikkit/ruby-bbcode-to-md gem source repo, although the tests don't run for me over on that repo, so maybe it's a good thing. |
harry-wood
force-pushed
the
lint-spelling
branch
from
b6c3962
to
cfc4a04
Compare
|
@nlalonde This look ok to you? Any chance of a merge if good? We have a few other improvements for ruby-bbcode-to-md and discourse fluxBB importer lined up. |
Swap out tab characters for spaces to give consistent indenting. Drop trailing whitespace characters at the ends of lines. Add a consistent trailing newline on every file. Done using rubocop: `rubocop --only Layout/IndentationStyle --autocorrect` `rubocop --only Layout/TrailingWhitespace --autocorrect` `rubocop --only Layout/TrailingEmptyLines --autocorrect`
harry-wood
force-pushed
the
lint-spelling
branch
from
cfc4a04
to
4d59682
Compare
|
@harry-wood I think this PR should be closed, everything from here is already in #6 |
|
Yes I thought this would be a quick and easy one to merge, but for the sake of clarity maybe it's best if I just leave my big PR open |
Fix some minor code lint: Swap tab characters for spaces. Remove trailing whitespace on the end of lines. Standard newline on the end of file.
(This is all minor stuff, although these particular whitespace things make working with code difficult because my IDE will auto-fix them, so it feels a lot tidier to fix them all at once like this)
+ Fix a few typos in comments.