Add error message to TestAddInvalidFirstArgTypeIgnored #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thenickcox
force-pushed
the
add_assertion_messages
branch
from
598584d
to
0f4fc6b
Compare
|
This looks great, thanks for adding! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there. I'm new to goment, but I love it, and it saved me from the misery of go's standard date library, so I wanted to contribute.
I noticed the need for assertion messages on your TODO. So here's a preliminary PR to make sure I'm on the right track.
Basically looking for feedback, and if this is helpful, I can add error messages to more assertions.
Thanks for making this great library.