Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Commits on Nov 4, 2009
Commits on Nov 3, 2009
  1. @theory

    Contributor popup fix.

    theory authored
    Fix the contributor association popup so that hitting the "Enter" key to
    perform a search no longer deletes contributors you've just added
    [#112 state:resolved].
  2. More adjustments to address bug #89 in IE7. Now fixed.

    phillipadsmith authored
  3. @theory

    Merge branch 'phillip/master'

    theory authored
  4. @theory

    Did not mean to commit that.

    theory authored
  5. @theory

    Contributors can be deleted again.

    theory authored
    Looks like there was a thinko in 8a7d34b such
    that a select field was using the name for the id even when an `$id` argument
    was passed. So I've fixed it to use the `$id` and to fallback on the name when
    the `$id` isn't set. [#111 state:resolved].
    
    There seems to be an unrelated issue where submitting a search in the
    contributor popup by hitting "enter" instead of the "search" button causes any
    contributors already added to be forgotten. What happens is the "enter"
    submits the contributor's "Delete" button instead of the "Search" buttton.
    This is really irritating. I'm not sure how to fix it, though; I'll
    create a new bug to track it.
  6. @theory

    Update the XML schema with `sql_type`.

    theory authored
    Also moved the `Changes` notice for the `sql_type` change to the
    "Improvements" section.
  7. @theory

    Add the `sql_type` element to the export of field types from SOAP. This

    theory authored
    prevents the SOAP server from having to guess the SQL type of a field type
    when updating an element type. Thanks to David Oliveira for the report
    [#79 state:resolved].
  8. @theory

    Fix alert type rule deletion.

    theory authored
    Alert type rules can once again be deleted from the UI. Thanks to Scott for
    the report [#81 state:resolved].
  9. @theory

    Passing a false value for the C<published_version> parameter to the C…

    theory authored
    …<list()>
    
    method of Bric::Biz::Asset::Business::Story, Bric::Biz::Asset::Business::Media,
    and Bric::Biz::Asset::Template now works as expected, returning the latest
    version of all stories regardless of their publish status, rather than no
    stories at all (Bug #1).
  10. @theory

    Added test for `published_version`.

    theory authored
    It seems to work, despite what I reported in Ticket #77.
Commits on Oct 30, 2009
  1. @theory

    Exploit DBI callbacks to make MySQL behave.

    theory authored
    Fixed compatibility issues on MySQL. Bricolage now sets `sql_mode` when it
    connects to the database, so that MySQL itself does not have to globally set
    that option, as it could cause conflicts with other apps running on MySQL.
    Also removed the attempt to set C<sql_mode> globally at installation time; it
    was bad manners, really.
    
    I used the DBI's callback support to make this work, so bumped up the minimum
    required DBI to 1.49. That's five years old already, so everyone should be
    fine.
Commits on Oct 17, 2009
  1. @theory

    Fixed Bug #82, where files with spaces weren't properly distributed.

    theory authored
    * Added `unescape_uri()` to Bric::Util::ApacheUtil.
    * Updated the various URI-processing methods in Bric::Util::Trans::FS
      to properly escape or unescape URIs as appropriate.
    * Wrote tests for the URI-processing methods in Bric::Util::Trans::FS.
    * Fixed `PREVIEW_LOCAL` block in Bric::Util::Burner to convert a URI to a
      directory with the improved `uri_to_dir()` method in Bric::Util::Trans::FS.
    * Updated the distribution movers (FS, FTP, and SFTP) to convert from URIs
      to file-system paths. Left WebDAV alone, since it should actually use URIs.
Commits on Oct 16, 2009
  1. @theory
  2. Fixed IE6 bug that was hiding the sideNav layer if the mainContent la…

    phillipadsmith authored
    …yer is not tall enough #88
Commits on Oct 15, 2009
  1. Merge branch 'master' of git://github.com/bricoleurs/bricolage

    phillipadsmith authored
    Conflicts:
    
    	lib/Bric/Changes.pod
Commits on Oct 13, 2009
  1. @theory

    Fixed a couple of typos.

    theory authored
Commits on Aug 31, 2009
  1. @theory

    Fixed a bug in find_or_create_alternate()

    theory authored
    Fixed a bug in `find_or_create_alternate()` where an element type is passed
    with a different setting for its `top_level` attribute than is the value of
    the `top_level` attribute of the original image's element type. This caused
    problems because it looked for an existing image using the wrong URI. So I
    hacked in a workaround to fool the current image into using the alternat's
    element type when determining the URI, so that the URI should always be the
    same. I ran into this in production for The Tyee, where editors were trying to
    create non-fixed thumbnails for fixed images. This caused some pretty serious
    indigestion. The workaround is a bit of a hack, but it's clean and works well.
    I updated the test suite to replicate the issue before patching, so we do have
    a proper regression test for the issue.
Commits on Aug 28, 2009
  1. @theory
  2. @theory

    Ignore `Makefile`.

    theory authored
  3. @theory

    Improved error handling in Bric::Dist::Client

    theory authored
    The error handling was not looking at response codes early enough. This change allows one to more easily identify problems, since an HTTP failure will now be properly output when there is a problem.
Commits on Aug 19, 2009
  1. @theory

    Refactor mark_as_published()

    theory authored
    I updated the docs for the new `mark_as_published()` method in
    `Bric::Biz::Asset::Business`, removing some invalid notes, adding some valid
    notes, and fixing some grammar nits. I also removed the call to `save()` at
    the end of the method, because no method should call `save()`; the user should
    always call it implicitly. I also changed the method so that it simply returns
    if the document is already marked as published, as there is no point in
    updating the publish date in this context. And finally, I added some tests
    for the new method.
  2. @paulorrock
Commits on Aug 17, 2009
  1. @theory

    Fix for Bug #93

    theory authored
    I fixed it already in rev_1_10, but the code required for master is a bit
    different, due to changes to the callbacks. So I've just made them by hand.
  2. @theory

    Rename `Makefile` to `Makefile.in`

    theory authored
    Rename `Makefile` to `Makefile.in` and change C<Makefile.PL` so that it
    creates `Makefile` from `Makefile.in`. This is so that `Makefile` is no longer
    changed in-place, which could get annoying when doing development.
Commits on Jul 27, 2009
  1. @theory
  2. @theory

    Don't adjust `kernel.shmall`.

    theory authored
Commits on Jul 21, 2009
  1. @theory

    Whitespace tweak.

    theory authored
    Signed-off-by: David E. Wheeler <david@justatheory.com>
  2. @theory

    Documented effect of `BLOB_SEARCH`.

    theory authored
    Documented the effect of `BLOB_SEARCH` on the `data_text` parameter to `Business->list()`.
    
    Signed-off-by: David E. Wheeler <david@justatheory.com>
Commits on Jul 12, 2009
  1. @theory

    Whitespace tweak.

    theory authored
Commits on Jun 16, 2009
  1. @theory
  2. @theory
  3. @theory

    Documented effect of `BLOB_SEARCH`.

    theory authored
    Documented the effect of `BLOB_SEARCH` on the `data_text` parameter to `Business->list()`.
Something went wrong with that request. Please try again.