Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Support for large messages #4

Merged
merged 5 commits into from Mar 26, 2013

Conversation

Projects
None yet
2 participants
Contributor

keikku commented Mar 26, 2013

When reading large messages (>65k) from Riak, data arrives in chunks and current implementation doesn't work as it assumes the whole message arrives in single client.on('data') event. This adds support for such messages buffering the data until the whole message is read. Also adds tests for large put/get.

keikku added some commits Dec 28, 2012

Add support for large incoming messages
When reading large (>65k) messages from Riak, data sometimes
arrives in multiple chunks. Current version did break with
"oob"-error when it happened. This commit adds support for
such messages buffering the results until all data has arrived.
Owner

nlf commented Mar 26, 2013

I was only storing small data so never even thought about this. Thanks for the fix, and especially for the corresponding tests!

nlf added a commit that referenced this pull request Mar 26, 2013

Merge pull request #4 from keikku/master
Support for large messages

@nlf nlf merged commit a7189fd into nlf:master Mar 26, 2013

Contributor

keikku commented Mar 28, 2013

Hi

You're welcome! And thank you for creating such a nice Riak driver. My use case creates a lot of Riak-requests per user-request and I'm getting over 30% end-to-end perf gain using this instead of HTTP API.

Btw. It took a while for me too to get to >65k message size, and even then it was because of poor desing choise in my part. Good thing is that the driver now works with larger messages and I discovered a bad desing in my app.


Jani

On Mar 26, 2013, at 6:20 PM, Nathan LaFreniere notifications@github.com wrote:

I was only storing small data so never even thought about this. Thanks for the fix, and especially for the corresponding tests!


Reply to this email directly or view it on GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment