Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

genRxControl is NULL for pkncaControl() #75

Closed
billdenney opened this issue Mar 9, 2023 · 2 comments · Fixed by nlmixr2/nlmixr2est#326
Closed

genRxControl is NULL for pkncaControl() #75

billdenney opened this issue Mar 9, 2023 · 2 comments · Fixed by nlmixr2/nlmixr2est#326

Comments

@billdenney
Copy link
Contributor

@mattfidler, When I'm using pkncaControl(), the genRxControl item is not present. That causes an error at this line:

https://github.com/nlmixr2/nlmixr2est/blob/7204214a9aaa324ad5ac04055d88fda2ea49f02e/R/nlmixr2.R#L253

Should I set it to FALSE within pkncaControl() or does it make more sense to modify that line to check for NULL? Maybe make that line into isTRUE(.ctl$genRxControl)?

@billdenney
Copy link
Contributor Author

I'm not sure why it works some times and not others. It may be package load order.

@mattfidler
Copy link
Member

Its seeing if it can adjust parameters. Sometimes it can sometimes it cant. I suppose isTRUE makes more sense

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants