Bugfix: Use the culture when rendering the layout #1556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
304NotModified
force-pushed
the
fix-LogEventInfos-FormatProvider
branch
from
60eeaff
to
4d85f10
Compare
Current coverage is 76% (diff: 88%)@@ master #1556 diff @@
==========================================
Files 270 270
Lines 16318 16402 +84
Methods 2611 2622 +11
Messages 0 0
Branches 1775 1792 +17
==========================================
+ Hits 12432 12506 +74
- Misses 3483 3487 +4
- Partials 403 409 +6
|
304NotModified
pushed a commit
that referenced
this pull request
Aug 14, 2016
* Added option to not render empty literals on nested json objects (#1580) * Added option to not render empty objects on nested json objects * Add support for name parameter on (#1578) * Bugfix: Use the culture when rendering the layout (#1556) * Added unit tests * Use the correct culture for rendering the string * fix SL / fix tests * fix culture * split IFormatProvider and CultureInfo * added related test * update/expand tests * fix xplat * Allow overwriting possible nlog configuration file paths (#1469) * Allow overwriting possible nlog configuration file paths * Redesign after review * Added tests * Improvements after review * move statics to XmlLoggingConfiguration * FileTarget: Performance improvement for CleanupInvalidFileNameChars (#1582) * FileTarget: Performance improvement for CleanupInvalidFileNameChars * Added unit test * Update for NLog 4.3.7 * Update README.md [skip ci] * fix unit test (#1589) * Misc. fixes for .NET Core * Remove wrap projects
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1528
note: none of the current unit tests where (functional) changed