Performance: less allocation in FileTarget for CleanupInvalidFilePath #1694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snakefoot
force-pushed
the
FilePathLayoutCleanup
branch
from
c3634e9
to
f3e426b
Compare
Current coverage is 80% (diff: 100%)@@ master #1694 diff @@
==========================================
Files 274 274
Lines 16873 16874 +1
Methods 2666 2666
Messages 0 0
Branches 1872 1872
==========================================
+ Hits 13511 13512 +1
Misses 2929 2929
Partials 433 433
|
304NotModified
added
enhancement
|
Nice one! Thanks! |
304NotModified
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FilePathLayout - CleanupInvalidFilePath - Happy path should not allocate
This change is