Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cppcheck fixes #1760

Merged
merged 3 commits into from Sep 24, 2019
Merged
Changes from 1 commit
Commits
File filter...
Filter file types
Jump to…
Jump to file or symbol
Failed to load files and symbols.

Always

Just for now

Next

Correct a warning from cppcheck:

binary_reader.hpp:650: (style) Unsigned expression 'mant' can't be negative so it is unnecessary to test it

https://github.com/Xav83/nlohmann-json-cppcheck/commit/910a7d2b873dd7ae92ec81cced2bf73200ff4848/checks#step:5:84

Signed-off-by: Xav83 <x.jouvenot@gmail.com>
  • Loading branch information...
Xav83 committed Sep 19, 2019
commit b9dfdbe6be73bfa57e024ac45f7a184354f0f6f5
@@ -647,7 +647,7 @@ class binary_reader
const int exp = (half >> 10u) & 0x1Fu;
const unsigned int mant = half & 0x3FFu;
assert(0 <= exp and exp <= 32);
assert(0 <= mant and mant <= 1024);
assert(mant <= 1024);
switch (exp)
{
case 0:
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.