New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make some good doctests for nltk.model.NgramModel #396

Closed
alexrudnick opened this Issue Apr 24, 2013 · 2 comments

Comments

Projects
None yet
4 participants
@alexrudnick
Copy link
Member

alexrudnick commented Apr 24, 2013

I don't think there are any tests for NgramModel at all right now...

But there should be some.

Tests should include the obvious things like creating a model, using some different estimators, sampling from it. And also pickling and loading from a pickle.

@kmike

This comment has been minimized.

Copy link
Member

kmike commented Apr 25, 2013

There is a simple test in NgramModel.__init__ docstring (it could be executed using runtests.py script), but it only checks that there are no syntax errors and that entropy calculation works; +1 for proper NgramModel tests (esp. given all recently opened NgramModel tickets).

@Copper-Head

This comment has been minimized.

Copy link
Contributor

Copper-Head commented Aug 25, 2018

@stevenbird this can also be closed while we're at it!

@stevenbird stevenbird closed this Aug 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment