Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewind Wordnet data file after each lookup #2868

Merged
merged 1 commit into from Nov 4, 2021
Merged

Conversation

ekaf
Copy link
Contributor

@ekaf ekaf commented Oct 27, 2021

This fixes #2867. Rewinding Wordnet data files after each lookup may not be absolutely necessary, but it is safer.

Copy link
Member

@tomaarsen tomaarsen left a comment

Looks great to me. This seems to be the only occurrence of seek other than in get_version. I'm all in favor of setting the file pointer back at the starting position like this. I'll give others a few days to comment on this in case they have something to add.
Thanks @ekaf!

@stevenbird stevenbird merged commit ec1d49d into nltk:develop Nov 4, 2021
16 checks passed
@stevenbird
Copy link
Member

@stevenbird stevenbird commented Nov 4, 2021

Thanks @ekaf

@ekaf ekaf deleted the hotfix-#2867 branch Nov 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants