Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update links to the nltk book #2895

Merged
merged 1 commit into from Nov 28, 2021
Merged

Update links to the nltk book #2895

merged 1 commit into from Nov 28, 2021

Conversation

dannysepler
Copy link
Contributor

@dannysepler dannysepler commented Nov 28, 2021

Closes #2891

@stevenbird stevenbird merged commit ca7950c into nltk:develop Nov 28, 2021
16 checks passed
@stevenbird
Copy link
Member

@stevenbird stevenbird commented Nov 28, 2021

Thanks @dannysepler

@tomaarsen
Copy link
Member

@tomaarsen tomaarsen commented Nov 28, 2021

For me, the old links of https://www.nltk.org/book work on both Firefox and Chrome, and redirect to https://www.nltk.org/book/.

The links that fail for me (on Firefox) are:

http://nltk.org/book
https://nltk.org/book

The following links work:

https://www.nltk.org/book
https://www.nltk.org/book/
www.nltk.org/book/
www.nltk.org/book

I can't really explain it. It's definitely something to do with the inclusion of www. That said, this PR can be merged without issues.

@dannysepler
Copy link
Contributor Author

@dannysepler dannysepler commented Nov 28, 2021

You're right @tomaarsen! Those two links also don't work for me, whereas the other links all work for me. So I'm guessing this PR didn't actually do anything (oops) and the actually issue isn't closed yet. Rather, it has more to do with links on the website rather than in the nltk repository itself

I opened this in the nltk.github.com repository instead nltk/nltk.github.com#20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants