Fix FileNotFoundError when the download_dir is a non-existing nested folder#2910
Merged
tomaarsen merged 2 commits intonltk:developfrom Dec 13, 2021
sp1thas:fix/nested-download-dir
Merged
Fix FileNotFoundError when the download_dir is a non-existing nested folder#2910tomaarsen merged 2 commits intonltk:developfrom sp1thas:fix/nested-download-dir
FileNotFoundError when the download_dir is a non-existing nested folder#2910tomaarsen merged 2 commits intonltk:developfrom
sp1thas:fix/nested-download-dir
Conversation
…when trying to use non-existing nested folders
Contributor
|
I wonder how easy it would be to add tests for this... pytest has some fixtures to create temporary directories. |
Member
|
Perfect! Thanks a bunch @sp1thas. Great tests, too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The purpose of this PR is to resolve #2904 by replacing the
os.mkdirwithos.makedirsin order to preventFileNotFoundErrorwhen thedownload_diris a non-existing nested directory (parent direcotry does not exists)